-
-
Notifications
You must be signed in to change notification settings - Fork 426
feat(YouTube - Swipe controls): Add option for vertical progress bar #4811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...main/java/app/revanced/extension/youtube/swipecontrols/SwipeControlsConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
...main/java/app/revanced/extension/youtube/swipecontrols/SwipeControlsConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java
Outdated
Show resolved
Hide resolved
...c/main/java/app/revanced/extension/youtube/swipecontrols/views/SwipeControlsOverlayLayout.kt
Outdated
Show resolved
Hide resolved
...c/main/java/app/revanced/extension/youtube/swipecontrols/views/SwipeControlsOverlayLayout.kt
Outdated
Show resolved
Hide resolved
...main/java/app/revanced/extension/youtube/swipecontrols/SwipeControlsConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
I noticed here that in fullscreen portrait mode the horizontal progress bar is slightly covered by the front camera. |
I think that only affects thru hole punch cameras. You could adjust the location based on See https://developer.android.com/develop/ui/views/layout/display-cutout |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
for some reason, in fullscreen mode only and when I add a margin for the camera cutout, everything is fine in fullscreen portrait mode, but in landscape fullscreen mode, these margins are also preserved, which should not be the case. It's bad that there's no variable for fullscreen portrait mode, that would solve the problem quickly, but now need to think how solve this problem. |
What about the window display frame?
|
Not sure if this will work, as the status bar is hidden in fullscreen mode. Or do you mean to determine which side the status bar is on and add a inset? |
I meant to check if just the status bar is visible using the window frame I don't think the left/right insets are needed to adjust for the camera hole. When in landscape fullscreen the 'top' inset will be the correct side (and not the unrotated top/bottom side of the screen). |
I think can leave a 20f topMargin as a solution of the problem. |
Anything todo before merging? |
Everything seems fine, ready to merge. |
# [5.21.0-dev.10](v5.21.0-dev.9...v5.21.0-dev.10) (2025-04-23) ### Features * **YouTube - Swipe controls:** Add option for vertical progress bar ([#4811](#4811)) ([ebee07e](ebee07e))
This comment was marked as spam.
This comment was marked as spam.
I don't understand what you're talking about, the swipe behavior hasn't changed. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
I understand that you misread. The swipe behavior has not changed, brightness on the left, volume on the right. The changes you are confusing only apply to the vertical swipe style. This is done for convenience, because when swiping from the left, the swipe overlay will be hidden under your finger, so I decided to show it opposite, on the right. Also, icons and values should now display correctly according to screen density without increasing padding. If everything is correct, you should see something like the screenshot above. |
This comment was marked as spam.
This comment was marked as spam.
# [5.21.0](v5.20.1...v5.21.0) (2025-04-25) ### Bug Fixes * `Hide ADB status` patch ([#4814](#4814)) ([dc89be0](dc89be0)) * **GmsCore Support:** Correct the description to refer to the app being patched ([2bbcf9d](2bbcf9d)) * **Wide search bar:** Fix patching `19.16.39` ([433dbc3](433dbc3)) * **YouTube - Change start page:** Add option to always override start page on app launch ([#4832](#4832)) ([5062e24](5062e24)) * **YouTube - Disable auto captions:** Correctly hide captions with YT 20.12 ([5ecbe82](5ecbe82)) * **YouTube - Hide video action buttons:** Add option to hide 'Ask' button ([#4852](#4852)) ([43bcf5a](43bcf5a)) * **YouTube - Hide video action buttons:** Hide A/B layout buttons ([4db5d3c](4db5d3c)) * **YouTube - Wide search bar:** Do not force phone layout for tablet devices ([#4827](#4827)) ([0cb38f9](0cb38f9)) ### Features * Add `Hide ADB status` patch ([#4585](#4585)) ([1ea8047](1ea8047)) * **X / Twitter:** Support version `10.86.0-release.0` ([#4805](#4805)) ([655b390](655b390)) * **YouTube - Swipe controls:** Add option for vertical progress bar ([#4811](#4811)) ([ebee07e](ebee07e)) * **YouTube:** Support version `20.12.46` ([#4779](#4779)) ([703359f](703359f))
This pull request introduces a new vertical swipe overlay style for the Swipe controls, along with several enhancements to improve user experience and customization.
Also closes #4669 and #4571
Changes
New Vertical Swipe Overlay Style:
VERTICAL
andVERTICAL_MINIMAL
).Screen Size Adaptation:
Overlay Style Selection in Settings:
HORIZONTAL
,CIRCULAR
,VERTICAL
, or their minimal variants).Progress Bar Color Customization:
Overlay Text Adjustment: