refactor: Log if the flag is enabled

Author: LisoUseInAIKyrios

patches/src/main/kotlin/app/revanced/patches/youtube/layout/returnyoutubedislike/ReturnYouTubeDislikePatch.kt

@@ -180,7 +180,8 @@ val returnYouTubeDislikePatch = bytecodePatch(
             // Turn off a/b flag that enables new code for creating litho spans.
             // If enabled then the litho text span hook is never called.
             // Target code is very obfuscated and exactly what the code does is not clear.
-            textComponentFeatureFlagFingerprint.method.returnEarly(false)
+            // Return late so debug patch logs if the flag is enabled.
+            textComponentFeatureFlagFingerprint.method.returnLate(false)
         }
 
         // Player response video id is needed to search for the video ids in Shorts litho components.

patches/src/main/kotlin/app/revanced/util/BytecodeUtils.kt

@@ -607,29 +607,54 @@ fun BytecodePatchContext.forEachLiteralValueInstruction(
 }
 
 /**
- * Return the method early.
+ * Overrides the first instruction of a method with a constant return value.
+ * None of the method code will ever execute.
  */
-fun MutableMethod.returnEarly(bool: Boolean = false) {
+fun MutableMethod.returnEarly(overrideValue: Boolean = false) = overrideReturnValue(overrideValue, false)
+
+/**
+ * Overrides all return statements with a constant value.
+ * All method code is executed the same as unpatched.
+ *
+ * @see returnEarly
+ */
+internal fun MutableMethod.returnLate(overrideValue: Boolean = false) = overrideReturnValue(overrideValue, true)
+
+private fun MutableMethod.overrideReturnValue(bool: Boolean, returnLate: Boolean) {
     val const = if (bool) "0x1" else "0x0"
 
-    val stringInstructions = when (returnType.first()) {
-        'L' ->
+    val instructions = when (returnType.first()) {
+        'L' -> {
             """
                 const/4 v0, $const
                 return-object v0
             """
+        }
 
-        'V' -> "return-void"
-        'I', 'Z' ->
+        'V' -> {
+            if (returnLate) throw IllegalArgumentException("Cannot return late for method of void type")
+            "return-void"
+        }
+
+        'I', 'Z' -> {
             """
                 const/4 v0, $const
                 return v0
             """
+        }
 
         else -> throw Exception("Return type is not supported: $this")
     }
 
-    addInstructions(0, stringInstructions)
+    if (returnLate) {
+        findInstructionIndicesReversed {
+            opcode == RETURN || opcode == RETURN_OBJECT
+        }.forEach { index ->
+            addInstructionsAtControlFlowLabel(index, instructions)
+        }
+    } else {
+        addInstructions(0, instructions)
+    }
 }
 
 /**