Skip to content

Release: common@3 #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Release: common@3 #1179

wants to merge 29 commits into from

Conversation

josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented May 1, 2025

Release branch for common major 3.0

  • remove map
  • add new map
  • tidy and update expandreferences
  • remove axios
  • export lodash

hunterachieng and others added 22 commits April 24, 2025 18:28
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
* feat: update rapidpro

Signed-off-by: Hunter Achieng <[email protected]>

* feat: add changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: remove config and fix r`return await`

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: remove export of http

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset with removal of http export

Signed-off-by: Hunter Achieng <[email protected]>

* fix: remove nock

Signed-off-by: Hunter Achieng <[email protected]>

---------

Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
…1171)

* feat: use common-request

Signed-off-by: Hunter Achieng <[email protected]>

* feat: add changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset

Signed-off-by: Hunter Achieng <[email protected]>

---------

Signed-off-by: Hunter Achieng <[email protected]>
…ptors into feature/1120-common-migration

Signed-off-by: Hunter Achieng <[email protected]>
common: remove deprecated expandreferences and update common versions
* remove common.map

* changeset

* typo

* remove map from salesforce and mogli

* changesets
@josephjclark
Copy link
Collaborator Author

hmm. Since the util refactor is looking too big and complicated, maybe we should release this as-is 🤔

I'll try and look at the docs thing on #1173. If there's a solution for the sake of a couple of hour's work, we'll do it. Otherwise we'll close that issue and never do it. It may just be too expensive

@josephjclark
Copy link
Collaborator Author

I think we made a mistake with rapidpro here, and maybe others. But I don't want to take time now to fix them - we can roll in fixes later if it becomes relevant.

Basically rapidpro no longer exports http. That's wrong, it should continue to export http. But it's a different version of http because it's now exporting the common 3 http namespace, not the common 1 namespace.

Let's leave this for now, I just wanted to leave a note for the record

@josephjclark
Copy link
Collaborator Author

Also, on this branch, can we review all http exports?

Common exports some very low level, generic http helpers, They don't do any auth stuff for you and they must take absolute URLs. They don't use config. This is fine.

If an adaptor declares its own http helpers, those helpers are not generic. They're bound to that service. And so that adaptor must not export the common http namespace. Because it's confusing and the two conflict.

So now I'm in doubt whether any adaptors should export common http at all. It sends the wrong message doesn't it? We usually say that steps should not send external HTTP requests. But where we export common http we sort of allow it.

I want to think about this and come back to it later.

Bumps [undici](https://github.com/nodejs/undici) from 5.28.5 to 5.29.0.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.5...v5.29.0)

---
updated-dependencies:
- dependency-name: undici
  dependency-version: 5.29.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@josephjclark
Copy link
Collaborator Author

Going to veto the util namespace on this branch. Let's just focus on getting common 3.0 out of door.

@josephjclark josephjclark self-assigned this Jun 6, 2025
hunterachieng and others added 2 commits June 9, 2025 14:32
…dabot/npm_and_yarn/undici-5.29.0

Signed-off-by: Hunter Achieng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants