rapidpro: migrate from deprecated common-http to fetch
#1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
hunterachieng
changed the base branch from
main
to
feature/1120-common-migration
|
Great notes in the PR body here, thanks! |
josephjclark
requested changes
Apr 28, 2025
There was a problem hiding this comment.
In the exports of Adaptor.js, at the bottom of the file, I can see that http is exported, with a comment.
This comment is now outdated. I also think we should NOT export http at this time. I'd just remove that whole line. And maybe mention this in the changelog too (the http namespace has been removed)
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
|
|
josephjclark
merged commit bc409de
into
feature/1120-common-migration
1 of 2 checks passed
josephjclark
pushed a commit
that referenced
this pull request
May 1, 2025
* feat: update rapidpro Signed-off-by: Hunter Achieng <[email protected]> * feat: add changeset Signed-off-by: Hunter Achieng <[email protected]> * fix: remove config and fix r`return await` Signed-off-by: Hunter Achieng <[email protected]> * fix: update changeset Signed-off-by: Hunter Achieng <[email protected]> * fix: remove export of http Signed-off-by: Hunter Achieng <[email protected]> * fix: update changeset with removal of http export Signed-off-by: Hunter Achieng <[email protected]> * fix: remove nock Signed-off-by: Hunter Achieng <[email protected]> --------- Signed-off-by: Hunter Achieng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
rapidprofrom deprecatedcommon-httptofetchFixes #1120
Details
The current
rapidprois using the deprecatedcommon-http.We resorted to using
fetchfromundiciascommon.requestreturns403AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.