Skip to content

Common adaptor migration #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josephjclark opened this issue Apr 7, 2025 · 0 comments · Fixed by #1160 or #1166
Closed

Common adaptor migration #1120

josephjclark opened this issue Apr 7, 2025 · 0 comments · Fixed by #1160 or #1166
Assignees
Labels
common major to be done in a major version of common P3 Priority Level

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented Apr 7, 2025

This replaces #306 #307 and #317

The aim is to use the new common expandReferences APIs and remove the old stuff.

The aim is for all adaptors to be on workspace:* and to remove legacy code

Use new expand references

For any affected adaptors:

  • Remove expandReferences in Adaptor.js
  • All adaptor should import expandReferences from common/util

Migrate common Versions

Some adaptors are fixed on an old common version, eg, progres

Usually this is because of expandReferences or http

We should aim to:

  • Update the expandReferences
  • If the adaptor used to export common.http, it should now export the NEW http
  • Replace the implementation on old http with an implementation on new http (we probably can't test this but changes should be minor)
  • if anything gets complicated, make noise!!

For any of these adaptors, we should check if they are being used on v2

Set adaptors to workspace:*

All adaptors should depend on workspace:*. Anything on semver should be able to be replaced trivally

Bump Common ?

if we remove any functions, we have to bump common to a new major. This might involve more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common major to be done in a major version of common P3 Priority Level
Projects
Status: Closed
3 participants