Skip to content

progres: migrate from deprecated common-http to common-request #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Apr 29, 2025

Summary

Migrate from deprecated common-http to common-request

Fixes #1120

Details

  • Migrate from common.http to common.request.
  • Remove axios and nock from progres.
  • Remove exportation of http from common, and the exportation of axios

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@josephjclark josephjclark merged commit 87b4f2e into feature/1120-common-migration Apr 29, 2025
2 checks passed
@josephjclark josephjclark deleted the feature/upgrade-progres branch April 29, 2025 13:51
josephjclark pushed a commit that referenced this pull request May 1, 2025
…1171)

* feat: use common-request

Signed-off-by: Hunter Achieng <[email protected]>

* feat: add changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset

Signed-off-by: Hunter Achieng <[email protected]>

* fix: update changeset

Signed-off-by: Hunter Achieng <[email protected]>

---------

Signed-off-by: Hunter Achieng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants