-
Notifications
You must be signed in to change notification settings - Fork 349
Health Analyzer Changes #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Coll6
wants to merge
6
commits into
Monkestation:master
Choose a base branch
from
Coll6:healthtry2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Health Analyzer Changes #6802
+570
−471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2025
Open
#6832 I've narrowed down to this testmerge. |
I dont understand whats going on there the code explicitly sets the base brain item as organ_flags = ORGAN_ORGANIC | ORGAN_VITAL | ORGAN_PROMINENT |
notghosti
reviewed
May 28, 2025
This was referenced May 28, 2025
Open
Open
This was referenced May 29, 2025
This was referenced Jun 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tg pr 86666
Ports tg pr 76350 fixes: #6832 fixes: #6830
fixes: #6596
fixes: #5024
fixes: #6797
Ports some changes for the health analyzer and fixes a couple of bugs related to monkestation changes.
Why It's Good For The Game
This just ports the nicer interface from tg and adds support for satyrs alcohol differences. Also fixes the bug causing mobs that require hearts to not show them. Also fixes mobs that don't require hearts showing theirs is missing adding confusion. Also adds support for the spleen organ that was added.
Changelog
🆑Siro
qol: Health Analyzer readout improvements.
qol: Alerts to consume alcohol if they have the living_drunk component.
code: Ports tgstation#76350 organ_flags and status merged. Fixes purist issues.
fix: Spleen organ now properly handled by the Health Analyzer readout.
fix: Properly displays when the heart is missing.
fix: DNA Infuser will not remove organs with the ORGAN_UNREMOVABLE flag
/:cl: