Skip to content

Make stack merging much less of a potential lagfest #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented May 7, 2025

About The Pull Request

Ports tgstation/tgstation#91015

currently a draft PR, to avoid this being merged before the upstream version is finalized and merged.

this refactors stack merging stuff - it's done in LateInitialize and Moved now, rather than Initialize, with every stack individually registering COMSIG_ATOM_ENTERED on its turf to trigger a merge.

thanks to MrMelbert for the help in the tg discord

Why It's Good For The Game

meow number go down

Changelog

🆑 Absolucy, Melbert
refactor: Stack merging has much less potential for causing large amounts of server lag now.
/:cl:

@Absolucy Absolucy added Process: do not merge don't merge this ffs Feature: Refactor/Rework Completely redoing a larger thing / recoding a thing Code: Performance / Optimization the number going down makes me happy :3 Process: should testmerge PR should be testmerged first labels May 7, 2025
@Absolucy Absolucy marked this pull request as draft May 7, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Performance / Optimization the number going down makes me happy :3 Feature: Refactor/Rework Completely redoing a larger thing / recoding a thing Process: do not merge don't merge this ffs Process: should testmerge PR should be testmerged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant