Reduce some memory usage #5764
Merged
Reduce some memory usage #5764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for some reason, despite not even being used
Absolucy
added
Code: Performance / Optimization
LikeLakers2
suggested changes
Mar 3, 2025
| @@ -9,7 +9,6 @@ GLOBAL_VAR_INIT(starlight_color, pick(COLOR_TEAL, COLOR_GREEN, COLOR_CYAN, COLOR | |||
| temperature = TCMB | |||
| thermal_conductivity = OPEN_HEAT_TRANSFER_COEFFICIENT | |||
| heat_capacity = 700000 | |||
| var/starlight_source_count = 0 | |||
There was a problem hiding this comment.
I would use a comment here to indicate removal, as this variable exists over on tgstation.
Suggested change
| var/starlight_source_count = 0 | |
| //var/starlight_source_count = 0 //MONKESTATION REMOVAL: Unused variable, removed to save memory |
There was a problem hiding this comment.
i'm planning to remove it upstream too if there's not a reasonf or it
This was referenced Mar 3, 2025
Closed
This was referenced Mar 6, 2025
Closed
Open
Closed
Co-authored-by: MichiRecRoom <[email protected]>
Co-authored-by: MichiRecRoom <[email protected]>
This was referenced Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This does a few things to reduce memory usage, mostly removing some vars off of base types:
/atom. If anyone wants this back, they can refactor it to a component.cached_blood_dna_colorvar on/atomwas moved to/datum/forensicsweather_affectablevar on/turf- nothing anywhere ever actually changes it from the defaultTRUEWhy It's Good For The Game
I want to make these numbers smaller
Changelog
🆑
refactor: Removed some unused code and rearranged some other code to hopefully reduce server-side memory usage.
/:cl: