Donator Jobs and Holiday checks[DNM] #5703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coll6
changed the title
|
Added the "do not merge" label since you have "[DNM]" in the title. Not sure what other labels to put. By the way - if you want to temporarily prevent merging, you can mark the PR as a draft. |
I do want to get it TM'd just not merged until it has been tested. The label you picked is great just incase. These labels are applicable for what this PR is doing. [Code Improvement] [Feature] All I can think of right now. |
|
I'll throw in Code Improvement then - there's not really anything player-facing in this PR (yet), so I don't think Feature fits. |
Coll6
changed the title
This was referenced Mar 6, 2025
Closed
This was referenced Mar 8, 2025
This was referenced Mar 10, 2025
Closed
Open
This was referenced Mar 12, 2025
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds the flexibility to make jobs that can only be accessed by certain donator ranks. Adds a more generalized check so that more event related jobs and be easily added.
Why It's Good For The Game
Changelog
🆑Siro
add: Documentation for setting jobs to use the new checks.
code: Creates checks for job overrides. Flags for donator specific jobs and flags to override holiday tied jobs.
code: Ties jobs to the holiday system so they can be loaded but only accessible if its the season or if the donator rank meets the requirements.
code: All admins and mentors can bypass these checks.
/:cl: