Skip to content

[PORT] Two new brain traumas; plus, a rewritten Kleptomania #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LikeLakers2
Copy link
Collaborator

@LikeLakers2 LikeLakers2 commented Jan 27, 2025

About The Pull Request

This PR ports the following PR:

and additionally ports a fix for the above PR:

This is a summary of the list of changes:

  • Adds a new Mild-type brain trauma, "Possessive."
    • Occasionally, you'll become possessive of an item in a random hand slot foor a short time. This prevents you from dropping the item or moving it to another slot.
  • Adds a new Special-type brain trauma, "Primal Instincts."
    • Your character will occasionally be taken over by a monkey AI. You will still be in control, but you'll have to fight the monkey AI.
    • There is a high chance the monkey AI will be aggressive.
    • The monkey AI does not care what you're trying to do. It will drop items, take wearables off, and so much more. Woe be upon you if you get this brain trauma.
    • On the bright side, you can understand monkey language while your primal instincts are active.
  • Replaces our current Kleptomania with a new Kleptomania.
    • The chance for Kleptomania to activate is higher than before, but also has a 8-second cooldown every time it activates. It also won't activate if you've taken damage recently.
    • Before, you could only ever steal to your active hand - and as a result, your active hand had to be free for it to activate. Now, it can activate if any hand is free.
    • Kleptomaniacs now steal a random item, instead of the first one they see.
    • Kleptomaniacs who are pickpocketing now steal from a random valid victim, instead of the first one they see.

Why It's Good For The Game

Cool and interesting drain bramage mechanics!

New admin logs

The new traumas will generate a number of logs under the following circumstances:

  • When Possessive causes the owner to become (un)possessive of an item; located under the ATTACK logs, in orange
  • When Primal Instincts is activated/deactivated; located under the ATTACK logs, in orange
  • When a Kleptomaniac attempts to pick up an item off the ground; located under the ATTACK logs, in orange
  • When a Kleptomaniac attempts (or succeeds) a pickpocket; located under the ATTACK logs, in red
  • When someone is the victim of a Kleptomaniac pickpocket; located under the VICTIM logs, in orange

Changelog

🆑MichiRecRoom, MrMelbert
add: Adds a new Mild-type brain trauma, Possessive. Occasionally, an item you're holding in your hand will become undroppable for a short time.
add: Adds a new Special-type brain trauma, Primal Instincts. Occasionally, your character will be taken over by a (possibly aggressive) monkey AI.
add: Rewrites our Kleptomania atop the new Kleptomania. This brings a number of changes, including activating more frequently (but with a cooldown), and the ability for the trauma to steal to any available hand.
admin: New logs for the new brain traumas. See PR 5138 for the details of these logs, and where to find them.
/:cl:

MrMelbert and others added 7 commits January 27, 2025 16:11
- Adds "Primal Instincts" brain trama.
   - Special trauma
   - Randomly, your body will be taken over by monkey AI.
- You will still be in control of the body, but you will have to fight
against the monkey ai for actions.
- There is a probability the monkey AI that takes control is aggressive,
meaning it will attack anyone nearby.
   - While primal, you can understand monkey language.

- Adds "Kleptomania" brain trauma
   - Severe trauma
- When you have empty hands, you will passively try to pick up things
near you.
- There is no feedback message associated, so you may not even notice
you did this.
- This effect is temporarily disabled if you have taken damage recently.

- Adds "Possessive" brain trauma
   - Mild trauma
- Randomly, your held items will become undroppable for a short to
medium length of time.

I was looking through AI stuff recently and remembered we support
allowing AI controllers to work in cliented mobs, but we don't use it
anywhere (outside of adminbus)

So I wanted to add a brain trauma themed around that. Simple enough.

But I didn't want to PR just a single trauma, that's boring so I thought
of some additional ones. Just to spice up the other two trauma pools. I
especially wanted to add some traumas that interact with inventory and
items, because while a lot of our traumas involving how a person
interacts with the world, not many involve how a person interacts with
themself.

:cl: Melbert
add: Adds 3 Traumas: Primal Instincts (special), Kleptomania (severe),
and Possessive (mild)
/:cl:
rather than on, when the intent was for them to wake up immediately to
do make the mob attack or fight or do something

:cl: Melbert
fix: Primal Instincts and Living Flesh should be a tad more reactive
/:cl:
@LikeLakers2 LikeLakers2 marked this pull request as draft January 28, 2025 00:12
@LikeLakers2 LikeLakers2 marked this pull request as ready for review January 28, 2025 00:46
@notghosti notghosti added Feature: Feature The creature feature. featuring: the creature. Monkeys contains monkeys labels Jan 28, 2025
@LikeLakers2 LikeLakers2 marked this pull request as draft January 28, 2025 07:19
@LikeLakers2
Copy link
Collaborator Author

LikeLakers2 commented Jan 28, 2025

Converting this PR to a draft while I figure out what to do with Kleptomania.

While it was originally decided to replace our Kleptomania with the port's kleptomania, I'm starting to wonder if it's a better idea to keep the pickpocketing. Hopefully I can discuss this with the other coders (Pooba and Syndie Kate in particular) soon.

Once a course of action is decided on (and implemented, if necessary), I will undraft this PR.

@LikeLakers2 LikeLakers2 marked this pull request as ready for review January 28, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approval: admin approved PR is approved by admins Feature: Feature The creature feature. featuring: the creature. Monkeys contains monkeys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants