Skip to content

Disable HTTPS for CDNs #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkms opened this issue Mar 1, 2022 · 2 comments
Closed

Disable HTTPS for CDNs #1032

jkms opened this issue Mar 1, 2022 · 2 comments
Labels
feature-request New feature needs to be implemented. good first issue Good for newcomers.

Comments

@jkms
Copy link

jkms commented Mar 1, 2022 •
edited
Loading

Problem description

Heroic does not appear to be working with my LanCache setup. I suspect (but have not confirmed) that it's defaulting to SSL instead of HTTP.

Feature description

Please add an option to force HTTP instead of HTTPS so that my LanCache server can cache downloads

Alternatives

N/A

Additional information

LanCache: https://lancache.net/
@philipwilk philipwilk added the feature-request New feature needs to be implemented. label Apr 23, 2022
@philipwilk
Copy link
Collaborator

I think this might be an upstream issue as well bc i dont think legendary supports it.

@philipwilk philipwilk added the issue:upstream This is an issue with upstream packages. label Apr 23, 2022
@arielj
Copy link
Collaborator

arielj commented Jun 5, 2022

Actually, Legendary supports the --no-https option with this exact description Download games via plaintext HTTP (like EGS), e.g. for use with a lan cache, so it's should be fairly easy to implement (just a switch/boolean and adding the flag to the install command if the value is true)

@arielj arielj added good first issue Good for newcomers. and removed issue:upstream This is an issue with upstream packages. labels Jun 5, 2022
Keksgesicht pushed a commit to Keksgesicht/HeroicGamesLauncher that referenced this issue Jun 28, 2022
add '-no-https' to legendary args for LanCache compatibility
5c24c9a 
fixes issue Heroic-Games-Launcher#1032
Epic Games uses also only http for downloads
"repair" is the only option that has been ignored by this patch
Keksgesicht pushed a commit to Keksgesicht/HeroicGamesLauncher that referenced this issue Jun 28, 2022
add '--no-https' to legendary args for LanCache compatibility
5974a1a 
fixes issue Heroic-Games-Launcher#1032
Epic Games uses also only http for downloads.
Applied to the uses of legendary commands "install", "update" and "repair".
@Keksgesicht Keksgesicht mentioned this issue Jun 29, 2022
Merged
4 tasks
@Nocccer Nocccer closed this as completed Jul 18, 2022
@Keksgesicht Keksgesicht mentioned this issue Sep 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature needs to be implemented. good first issue Good for newcomers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arielj @jkms @philipwilk @Nocccer