-
-
Notifications
You must be signed in to change notification settings - Fork 480
[General] add optional '--no-https' flag for legendary args for LanCache compatibility #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[General] add optional '--no-https' flag for legendary args for LanCache compatibility #1538
Conversation
8c415e9
to
d3a5828
Compare
d3a5828
to
328408f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How did you add the changes in the translation files? check this https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Translations#how-to-add-new-translatable-strings Currently languages other than english and german will show an empty string instead of english. You should only add the key and the fallback in the code and use |
328408f
to
b5ceed5
Compare
This flag can be enabled via the advanced settings and gets applied to the uses of legendary commands "install", "update" and "repair".
b5ceed5
to
6471195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏽
@Keksgesicht thanks for the contribution :) |
fixes issue #1032
Epic Games uses also only http for downloads.
This flag is default disabled, can be enabled via the advanced settings and gets applied to the uses of legendary commands "install", "update" and "repair".
New settings option has translations for english and german. Other languages are missing.
Use the following Checklist if you have changed something on the Backend or Frontend: