[Fix] Not permanently saving downloadNoHttps config option #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
approved these changes
Sep 10, 2022
flavioislima
changed the title
4 tasks
flavioislima
added a commit
that referenced
this pull request
Sep 13, 2022
* [Feat] Proper check if heroic can communicate with internet (#1677) * Added ping to check internet connection * removed console.log * Make log of error more clear * Remove ping package and just use ping cli command * Return if one ping succeed * [i18n] Updated Translations (#1728) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Czech) Currently translated at 100.0% (358 of 358 strings) Translated using Weblate (Czech) Currently translated at 100.0% (358 of 358 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Shimon <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/cs/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Korean) Currently translated at 100.0% (358 of 358 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Moon Sungjoon <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ko/ Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Russian) Currently translated at 100.0% (358 of 358 strings) Translated using Weblate (Russian) Currently translated at 100.0% (358 of 358 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Sedative <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ru/ Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (Persian) Currently translated at 100.0% (358 of 358 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Parsa Shadab <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fa/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: Shimon <[email protected]> Co-authored-by: Moon Sungjoon <[email protected]> Co-authored-by: Sedative <[email protected]> Co-authored-by: Parsa Shadab <[email protected]> * Revert "[i18n] Updated Translations" (#1745) Revert "[i18n] Updated Translations (#1728)" This reverts commit 7f5d2b3. * [Tech] Switch from react-scripts to Vite & clean up everything to work with strict mode (#1633) * Change complete project structure - Rename "src" -> "src/frontend" - Rename "electron" -> "src/backend" - Move types.ts to "common/types.ts" * Switch from react-scripts + foreman + webpack + ts-loader -> Vite * Set GH_TOKEN and GITHUB_TOKEN in tests directly This just cleans up package.json a bit * Get SVG & JPG importing working in VSCode * Move type definitions into common/typedefs * Fixup tests * Rewrite large chunks of the backend to be compatible with strict mode * Modify frontend to reflect changes to type definition structure * Remove unused files These weren't necessary, at least as far as I can tell * Update translations * Fixup: Re-add `--filesystem` parameter for Proton Turns out refactoring a lot of stuff can introduce issues, who would've thought * Remove `build` script You never have to run this yourself, so it was a bit confusing to have. If you really need its functionality, `vite build` isn't that hard to type in on your own :^) * Fully remove all remnants of UE support * Add new 'codecheck' command This command can be used to make sure that no files in the project violate TS rules, since Vite itself doesn't check them It would probably be a good idea to add them to GH Workflows and/or pre-commit hooks, but I'm not too sure on how to do that * Update translation files * Fix translation files Not sure how this happens, but it seems they've gotten screwed up in the merge * Remove some more unnecessary files * Always get game updates from all libraries This fixes an issue where refreshing the library while only showing one library made the update icons of all the others disappear * Some misc code style changes * Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLauncher into beta * [Fix] Check if Legendary's `metadata` folder exists before trying to read it (#1785) * [Fix] Not permanently saving downloadNoHttps config option (#1797) fixing not permanently saving downloadNoHttps config option * Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLauncher into beta * [Fix] TypeError: Unexpected end of json (#1806) * remove useEffect double import * catch type error end of json * Added try catch * Add log prefix to see what runner fails * [Tech] Add codecheck to pre push and workflow (#1794) * Add codecheck to pre push and workflow * Add new workflow for codecheck * renaming * [Fix] Update legendary binaries (#1809) Update legendary binaries * fix: gog getGameinfo after clear the cache Co-authored-by: Niklas <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: Shimon <[email protected]> Co-authored-by: Moon Sungjoon <[email protected]> Co-authored-by: Sedative <[email protected]> Co-authored-by: Parsa Shadab <[email protected]> Co-authored-by: Mathis Dröge <[email protected]> Co-authored-by: Jan B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last pull request #1538 (for issue #1032) did not save the new option within the config file. So after closing heroic the option got lost.
Use the following Checklist if you have changed something on the Backend or Frontend: