fix: io decoded handling #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
force-pushed
the
fix/io-decoded-handling
branch
from
3005ca9 to
f197193
Compare
r4mmer
previously approved these changes
Apr 2, 2025
pedroferreira1
previously approved these changes
Apr 2, 2025
| @@ -238,7 +239,7 @@ export const handleVertexAccepted = async (context: Context, _event: Event) => { | |||
| const blockRewardOutput = outputs[0]; | |||
|
|
|||
| // add miner to the miners table | |||
| if (blockRewardOutput.decoded) { | |||
| if (isDecodedValid(blockRewardOutput.decoded)) { | |||
There was a problem hiding this comment.
decoded.address is required here, right?
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
andreabadesso
dismissed stale reviews from pedroferreira1 and r4mmer
via
b9af726
r4mmer
approved these changes
Apr 2, 2025
pedroferreira1
approved these changes
Apr 2, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
r4mmer
added a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After HathorNetwork/hathor-core#1250, the
decodedkey ofoutputandspent_output(inputs) is now returning an empty object when the script is unable to be parsed, causing our code to fail because we were expecting it to be null.Acceptance Criteria
decodeddecodedobject.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged