Skip to content

feat(events): change empty decoded from None to empty dict #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Mar 26, 2025

Motivation

Our wallet-service use case requested that empty decoded outputs in events should be represented as {} instead of None.

Acceptance Criteria

  • Change empty decoded outputs from None to {}.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Mar 26, 2025
@glevco glevco requested a review from jansegre as a code owner March 26, 2025 17:16
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Mar 26, 2025
Copy link

🐰 Bencher Report

Branchfeat/events/empty-decoded
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.63 m
(+0.01%)Baseline: 1.63 m
1.47 m
(89.99%)
1.80 m
(90.92%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (f534d0d) to head (05429b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
- Coverage   84.11%   84.09%   -0.02%     
==========================================
  Files         311      311              
  Lines       23868    23864       -4     
  Branches     3651     3649       -2     
==========================================
- Hits        20076    20068       -8     
- Misses       3074     3075       +1     
- Partials      718      721       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 27, 2025
@glevco glevco merged commit ad806ae into master Mar 31, 2025
17 of 18 checks passed
@glevco glevco deleted the feat/events/empty-decoded branch March 31, 2025 20:22
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants