Skip to content

fix: daemon was always using ssl regardless of config #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

andreabadesso
Copy link
Collaborator

Motivation

The fullnode was always using SSL when connecting to fullnodes

Acceptance Criteria

  • The daemon should be able to connect to fullnodes without using SSL

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Mar 26, 2025
@andreabadesso andreabadesso added the bug Something isn't working label Mar 26, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (Done) in Hathor Network Mar 26, 2025
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 26, 2025
@andreabadesso andreabadesso merged commit 8b6af1e into master Mar 26, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Mar 26, 2025
@andreabadesso andreabadesso deleted the fix/use-ssl branch March 26, 2025 15:21
@r4mmer r4mmer mentioned this pull request Apr 1, 2025
2 tasks
r4mmer added a commit that referenced this pull request Apr 2, 2025
…-lib-v2.1.1

* origin/master:
  fix: io decoded handling (#229)
  chore: bump version v1.8.0 (#226)
  fix: nft utils should be imported from common index (#223)
  fix: daemon was always using ssl regardless of config (#224)
@r4mmer r4mmer moved this from Waiting to be deployed to Done in Hathor Network Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants