Skip to content

refactor: big int #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

refactor: big int #658

wants to merge 53 commits into from

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Mar 5, 2025 •
edited
Loading

Summary

We should support rendering bigint values in all screens

Acceptance Criteria

  • BigInt values should be correctly handled with bigIntCoercibleSchema
  • We should update the wallet-lib to the latest version
  • No regression in core functionality

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Mar 5, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Mar 5, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Mar 5, 2025
@andreabadesso andreabadesso force-pushed the refactor/big-int branch 6 times, most recently from 79bc81a to a6d6fbe Compare March 5, 2025 01:27
@glevco glevco mentioned this pull request Mar 5, 2025
Closed
1 task
@andreabadesso andreabadesso force-pushed the refactor/big-int branch 4 times, most recently from c79f86e to 4c30b78 Compare March 9, 2025 15:18
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 9, 2025
@andreabadesso andreabadesso requested a review from r4mmer March 10, 2025 12:34
pedroferreira1
pedroferreira1 reviewed Mar 10, 2025
View reviewed changes
@pedroferreira1 pedroferreira1 moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 10, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to In Progress (WIP) in Hathor Network Mar 11, 2025
@andreabadesso andreabadesso force-pushed the refactor/big-int branch 3 times, most recently from 2731679 to 93e14a2 Compare March 12, 2025 14:37
andreabadesso
andreabadesso commented Mar 12, 2025
View reviewed changes
@andreabadesso andreabadesso force-pushed the refactor/big-int branch 3 times, most recently from 284b674 to 766e7f9 Compare March 20, 2025 15:23
@andreabadesso andreabadesso moved this from In Review (WIP) to In Progress (Done) in Hathor Network Mar 20, 2025
@pedroferreira1 pedroferreira1 moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 20, 2025
r4mmer
r4mmer requested changes Mar 24, 2025
View reviewed changes
@r4mmer r4mmer moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 24, 2025
@andreabadesso andreabadesso moved this from In Review (Done) to In Progress (WIP) in Hathor Network Mar 25, 2025
@andreabadesso andreabadesso requested a review from r4mmer March 26, 2025 15:20
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 28, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 31, 2025
@andreabadesso andreabadesso moved this from In Review (Done) to In Progress (WIP) in Hathor Network Apr 9, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Review (Done) in Hathor Network Apr 16, 2025
@andreabadesso andreabadesso moved this from In Review (Done) to In Progress (WIP) in Hathor Network Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Status: In Progress (WIP)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @pedroferreira1 @r4mmer