feat: rpc send tokens #659

andreabadesso · 2025-03-05T15:52:44Z

Screen.Recording.2025-03-09.at.15.43.59.mov

Acceptance Criteria

We should be able to handle sendTransaction RPC requests
We should be able to handle data outputs
We should register tokens used in outputs or inputs automatically
We should handle insufficient balance errors properly

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

src/reducers/reducer.js

src/components/Reown/ReownModal.js

src/sagas/reown.js

pedroferreira1 · 2025-03-12T00:45:25Z

src/components/Reown/SendTransactionModal.js

+      return '-';
+    }
+
+    return numberUtils.prettyValue(value);


We should format considering NFT as well.

Done, thanks

src/components/Reown/SendTransactionModal.js

src/components/Reown/SendTransactionRequest.js

pedroferreira1

I think this PR is missing the i18n files.

pedroferreira1 · 2025-03-18T14:05:45Z

src/components/Reown/SendTransactionRequest.js

+    if (!tokenId) {
+      return constants.DEFAULT_NATIVE_TOKEN_CONFIG.symbol;
+    }


I think we changed this in the desktop wallet PR. Now we don't have a default and you just check if it's the default native token UID

Refactored to be exactly like the hathor wallet

pedroferreira1 · 2025-03-18T14:06:28Z

src/components/Reown/SendTransactionRequest.js

+                  <Text style={styles.labelText}>{t`Data field`}</Text>
+                  <View style={styles.valueContainer}>
+                    <Text style={styles.monospace}>
+                      {output.data.join(',')}


We also need to change this, just like in the desktop wallet

pedroferreira1 · 2025-03-20T21:27:36Z

src/components/Reown/SendTransactionRequest.js

-    return numberUtils.prettyValue(value);
+    const isNFT = tokenId && helpersUtils.isTokenNFT(tokenId, tokenMetadata);
+
+    return numberUtils.prettyValue(value, isNFT ? 0 : constants.DECIMAL_PLACES);


After the decimal places refactor you should use the redux state here as well

locale/pt-br/texts.po

raul-oliveira

Looks good. I've placed some comments about the code base.

index.js

src/components/Reown/CreateTokenModal.js

src/components/Reown/ReownModal.js

raul-oliveira · 2025-03-26T15:12:43Z

src/screens/SendAmountInput.js

+                  onAmountUpdate={onAmountChange}
+                  value={amount}
+                  allowOnlyInteger={isNFT()}
+                  style={{ flex: 1 }}


add the comments from the prev version, it could be helpful in a future time

// we need this so the placeholder doesn't break in android // devices after erasing the text // https://github.com/facebook/react-native/issues/30666

Done! Thanks

raul-oliveira

Code looks good! Tks for addressing the refactors.

anafigueired · 2025-03-28T13:08:18Z

Hey! 👋 From a UX/UI perspective, here are some suggestions and questions:

Should we inform the user that this transaction comes from an external source? Even if it’s coming from Hathor Play or another known dApp.
Currently, if the user doesn’t have enough funds, the message shown is a bit generic. Suggestion: show something clearer like “Insufficient balance to accept this transaction”.
I made a small mockup with visual improvements for readability: added more spacing between output cards for clarity and
replaced the "Copy" text with an icon to keep the layout cleaner (see screenshot).

To avoid visual repetition and improve hierarchy, I grouped the outputs into two sections: Data Outputs and Address Outputs. I created two layout options for this and will attach both here.
Question: do you think it’s common to have many outputs? If so, we might want to consider a more scalable layout in the future.

The Figma file: https://www.figma.com/design/qQZ91mzazEgiGJbKs1mKUc/Nano-Contracts?node-id=3339-3113&t=DAVFJhGAkbykMYmN-1

andreabadesso requested a review from pedroferreira1 as a code owner March 5, 2025 15:52

andreabadesso self-assigned this Mar 5, 2025

andreabadesso added the enhancement New feature or request label Mar 5, 2025

andreabadesso added this to Hathor Network Mar 5, 2025

andreabadesso moved this to In Progress (Done) in Hathor Network Mar 5, 2025

andreabadesso moved this from In Progress (Done) to In Progress (WIP) in Hathor Network Mar 5, 2025

andreabadesso force-pushed the refactor/big-int branch 2 times, most recently from 06c1f1d to 925a29e Compare March 9, 2025 15:27

andreabadesso force-pushed the feat/rpc-send-tokens branch 3 times, most recently from 17ca208 to 5bc205f Compare March 9, 2025 18:42

andreabadesso requested a review from raul-oliveira March 9, 2025 18:46

andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 9, 2025

andreabadesso force-pushed the feat/rpc-send-tokens branch from e7301c4 to 091b89f Compare March 9, 2025 18:48

pedroferreira1 reviewed Mar 12, 2025

View reviewed changes

pedroferreira1 moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 12, 2025

andreabadesso force-pushed the refactor/big-int branch 2 times, most recently from 433c4fe to f395832 Compare March 12, 2025 15:14

andreabadesso force-pushed the feat/rpc-send-tokens branch from 091b89f to 71e796a Compare March 12, 2025 15:19

andreabadesso moved this from In Review (WIP) to In Progress (Done) in Hathor Network Mar 14, 2025

andreabadesso moved this from In Progress (Done) to In Progress (WIP) in Hathor Network Mar 17, 2025

andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 17, 2025

andreabadesso requested a review from pedroferreira1 March 17, 2025 15:15

pedroferreira1 reviewed Mar 18, 2025

View reviewed changes

pedroferreira1 moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 18, 2025

fix: clear tokens from other networks (#660)

dd23954

andreabadesso force-pushed the refactor/big-int branch 2 times, most recently from 2bce8bf to 98fb803 Compare March 20, 2025 15:56

andreabadesso moved this from In Review (WIP) to In Progress (WIP) in Hathor Network Mar 20, 2025

refactor: using bigIntCoercibleSchema on multiple screens.

d2588f9

refactor: move show modal actions to be close to each other

62a99a4

andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 20, 2025

pedroferreira1 approved these changes Mar 20, 2025

View reviewed changes

github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 20, 2025

pedroferreira1 reviewed Mar 20, 2025

View reviewed changes

locale/pt-br/texts.po Outdated Show resolved Hide resolved

locale/pt-br/texts.po Outdated Show resolved Hide resolved

chore: added missing translations

b87a1d4

andreabadesso force-pushed the feat/rpc-send-tokens branch from 8b7b0b7 to b87a1d4 Compare March 20, 2025 22:04

raul-oliveira approved these changes Mar 21, 2025

View reviewed changes

index.js Outdated Show resolved Hide resolved

src/components/Reown/CreateTokenModal.js Show resolved Hide resolved

src/components/Reown/ReownModal.js Outdated Show resolved Hide resolved

raul-oliveira self-requested a review March 21, 2025 16:31

andreabadesso added 5 commits March 26, 2025 10:50

refactor: using a dict to get the modal type

b6a6f2d

refactor: removed baseStyles since it was only used in connect modal

9bd80e8

refactor: SendAmountInput is now a function component

06a825d

refactor: stop ignoring logs

2d1d26c

refactor: SendConfirmScreen is now a function component

3c5bec6

raul-oliveira reviewed Mar 26, 2025

View reviewed changes

raul-oliveira approved these changes Mar 26, 2025

View reviewed changes

andreabadesso added 3 commits March 26, 2025 12:22

Merge branch 'refactor/big-int' into feat/rpc-send-tokens

dae45d6

docs: added missing comment

dd860fb

fix: skip serialization/deserialization for functions

b32c86d

andreabadesso moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 26, 2025

docs: better docs for navigation arguments

d54dc11

andreabadesso mentioned this pull request Apr 9, 2025

UI changes in reown/send-transactions #680

Open

tuliomir added 3 commits April 9, 2025 18:19

chore: Upgrades to latest react-native 72 (#655)

ca1ecdc

chore: Add pt-br as a mandatory language on CI (#673)

512fff5

fix: White bar below custom network (#674)

9ece4cf

andreabadesso moved this from In Review (Done) to In Progress (WIP) in Hathor Network Apr 28, 2025

andreabadesso added 3 commits April 29, 2025 12:12

Merge branch 'master' into feat/rpc-send-tokens

88c9caa

chore: using latest hathor-rpc-handler

d0b2935

refactor: defaulting to bigint instead of regular int

ecd1ad3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rpc send tokens #659

feat: rpc send tokens #659

andreabadesso commented Mar 5, 2025 •

edited

Loading

pedroferreira1 Mar 12, 2025

andreabadesso Mar 20, 2025

pedroferreira1 left a comment

pedroferreira1 Mar 18, 2025

andreabadesso Mar 20, 2025

pedroferreira1 Mar 18, 2025

andreabadesso Mar 20, 2025

pedroferreira1 Mar 20, 2025

raul-oliveira left a comment

raul-oliveira Mar 26, 2025

andreabadesso Mar 26, 2025

raul-oliveira left a comment

anafigueired commented Mar 28, 2025 •

edited

Loading

feat: rpc send tokens #659

Are you sure you want to change the base?

feat: rpc send tokens #659

Conversation

andreabadesso commented Mar 5, 2025 • edited Loading

Acceptance Criteria

Security Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedroferreira1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raul-oliveira left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raul-oliveira left a comment

Choose a reason for hiding this comment

anafigueired commented Mar 28, 2025 • edited Loading

andreabadesso commented Mar 5, 2025 •

edited

Loading

anafigueired commented Mar 28, 2025 •

edited

Loading