Skip to content

refactor: decimal places #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 4, 2025
Merged

refactor: decimal places #671

merged 12 commits into from
Apr 4, 2025

Conversation

andreabadesso
Copy link
Contributor

Acceptance Criteria

  • We should use decimal places from the serverInfo instead of using the constant one
  • We should refactor AmountTextInput to be a functional component

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso force-pushed the refactor/decimal-places branch from 2bce8bf to a5b7b9a Compare March 20, 2025 15:57
@andreabadesso andreabadesso self-assigned this Mar 20, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Mar 20, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (Done) in Hathor Network Mar 20, 2025
@andreabadesso andreabadesso mentioned this pull request Mar 20, 2025
Open
1 task
@andreabadesso andreabadesso changed the title fefactor: decimal places refactor: decimal places Mar 20, 2025
@andreabadesso andreabadesso force-pushed the refactor/decimal-places branch from a5b7b9a to fa734c8 Compare March 20, 2025 19:28
pedroferreira1
pedroferreira1 reviewed Mar 20, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 27, 2025
@andreabadesso andreabadesso merged commit 2671910 into refactor/big-int Apr 4, 2025
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Apr 4, 2025
@andreabadesso andreabadesso deleted the refactor/decimal-places branch April 4, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@raul-oliveira raul-oliveira raul-oliveira approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @pedroferreira1 @raul-oliveira