Skip to content

refactor: ignore confirmation modal #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andreabadesso
Copy link
Contributor

Acceptance Criteria

  • We should skip directly to the SendNanoContractRequestScreen instead of showing a modal first.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso force-pushed the refactor/ignore-confirmation-modal branch from 62b0c2c to 3007b54 Compare August 22, 2024 15:15
@andreabadesso andreabadesso added the enhancement New feature or request label Aug 22, 2024
@andreabadesso andreabadesso self-assigned this Aug 22, 2024
@andreabadesso andreabadesso force-pushed the refactor/ignore-confirmation-modal branch from 3007b54 to efb0b96 Compare August 26, 2024 12:43
@andreabadesso andreabadesso force-pushed the refactor/default-network branch 3 times, most recently from fb46e71 to 8a4734f Compare August 29, 2024 16:57
@andreabadesso andreabadesso changed the base branch from refactor/default-network to feat/enable-walletconnect August 29, 2024 17:07
@andreabadesso andreabadesso force-pushed the refactor/ignore-confirmation-modal branch from d577005 to 89ab357 Compare August 29, 2024 17:15
@andreabadesso andreabadesso changed the base branch from feat/enable-walletconnect to refactor/enable-walletconnect August 29, 2024 17:16
@andreabadesso andreabadesso merged commit 3d13088 into refactor/enable-walletconnect Aug 29, 2024
andreabadesso added a commit that referenced this pull request Aug 29, 2024
* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso added a commit that referenced this pull request Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso added a commit that referenced this pull request Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso added a commit that referenced this pull request Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso added a commit that referenced this pull request Aug 31, 2024
* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* refactor: enable walletconnect by default (#541)

* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* refactor: enabled walletconnect by default

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* feat: added sign oracle data request component and screen

* refactor: removed onReadMore

* refactor: skip confirmation on sign oracle data

* refactor: stop sending baseStyles to sign oracle request and refactored acceptedNc to acceptedData

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso added a commit that referenced this pull request Nov 6, 2024
* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* refactor: enable walletconnect by default (#541)

* feat: implement Nano Contract integration with Wallet Connect

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* chore: changed CI version to 18x and 20x

* refactor: enabled walletconnect by default

* chore: updated package-lock

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* refactor: ignore confirmation modal (#544)

* refactor: ignore modal confirmation screen

* refactor: added a config to skip walletconnect confirmation modals

* feat: skip confirmation modal on sign message modal as well

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* chore: added dependencies and shims needed by walletconnect

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* refactor: enabled walletconnect by default

* chore: updated walletconnect dependencies to be equal to the patch

* refactor: default network is nano testnet (#542)

* chore: add undeclared style

* refactor: rename effect requestTokens to requestUnregisteredTokens

* feat: fire sentry error notification for method info not found

* feat: improve title of Arguments component

* refactor: reanem style value to field

* fix: FeedbackContent margin style

Remarks:
The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* lint: comply with rules

* fix: typo

* refactor: using object destructuring in shims

* refactor: typo

* refactor: removed unused import on NanoContactTransactionHeader

* chore: removed walletconnect libraries from package

* feat: added hathor-rpc-handler from the deployed lib

* refactor: enabled walletconnect by default

* refactor: added nano testnet as default network

* feat: allow the user to select the nano testnet in network settings

* refactor: removed walletservice urls from constants on nano testnet

* refactor: remove nc status from tx details (#546)

* refactor: remove nc status from tx details
* feat: add status label for voided tx

* feat: add event coin token as default alongside with hathor (#547)

* feat: add register nano contract buttom if nc not registered on new nc transaction (#545)

* feat: add register nano contract buttom if nc not registered on new nc transaction
* feat: add failure feedback modal for Nano Contract registration failure
* feat: restore ready state of nano contract registration also in the success path

* refactor: skip directly to the ChoosePinScreen (#543)

* refactor: skip directly to the ChoosePinScreen

* refactor: added a constant to determine whether to show the confirmation screen

* refactor: default skip_seed_confirmation to true

---------

Co-authored-by: Alex Ruzenhack <[email protected]>

* feat: added sign oracle data request component and screen

* refactor: removed onReadMore

* refactor: skip confirmation on sign oracle data

* refactor: stop sending baseStyles to sign oracle request and refactored acceptedNc to acceptedData

---------

Co-authored-by: Alex Ruzenhack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants