refactor: default network is nano testnet #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
changed the base branch from
hathorplay-base
to
refactor/enable-walletconnect
alexruzenhack
approved these changes
Aug 22, 2024
pedroferreira1
approved these changes
Aug 24, 2024
src/constants.js
Outdated
Comment on lines
202
to
203
| walletServiceUrl: WALLET_SERVICE_TESTNET_BASE_URL, | ||
| walletServiceWsUrl: WALLET_SERVICE_TESTNET_BASE_WS_URL, |
There was a problem hiding this comment.
Is it the same as our public testnet? I know that we won't allow Hathor Play to connect to wallet service but is it a required key?
There was a problem hiding this comment.
They're not required, I agree we should remove them, done
andreabadesso
force-pushed
the
refactor/enable-walletconnect
branch
from
edb2356 to
95c2b42
Compare
andreabadesso
force-pushed
the
refactor/default-network
branch
from
e898c1a to
5725b40
Compare
andreabadesso
force-pushed
the
refactor/enable-walletconnect
branch
from
95c2b42 to
4672daa
Compare
andreabadesso
force-pushed
the
refactor/default-network
branch
from
5725b40 to
fb46e71
Compare
Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.
* refactor: remove nc status from tx details * feat: add status label for voided tx
…c transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path
* refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true
andreabadesso
force-pushed
the
refactor/default-network
branch
from
fb46e71 to
8a4734f
Compare
andreabadesso
added a commit
that referenced
this pull request
Aug 29, 2024
* feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 29, 2024
* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 31, 2024
* feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 31, 2024
* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Aug 31, 2024
* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enable walletconnect by default (#541) * feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]> * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enabled walletconnect by default * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * feat: added sign oracle data request component and screen * refactor: removed onReadMore * refactor: skip confirmation on sign oracle data * refactor: stop sending baseStyles to sign oracle request and refactored acceptedNc to acceptedData --------- Co-authored-by: Alex Ruzenhack <[email protected]>
andreabadesso
added a commit
that referenced
this pull request
Nov 6, 2024
* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enable walletconnect by default (#541) * feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]> * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enabled walletconnect by default * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * feat: added sign oracle data request component and screen * refactor: removed onReadMore * refactor: skip confirmation on sign oracle data * refactor: stop sending baseStyles to sign oracle request and refactored acceptedNc to acceptedData --------- Co-authored-by: Alex Ruzenhack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist