feat: sign oracle data #509

andreabadesso · 2024-07-16T16:30:54Z

Acceptance Criteria

We should handle sign oracle data requests

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

pedroferreira1 · 2024-08-30T21:08:21Z

src/components/WalletConnect/WalletConnectModal.js

+          <SignOracleDataModal
+            {...walletConnectModal}
+            onDismiss={onDismiss}
+            baseStyles={baseStyles}


Should we remove it as we removed the others?

Done, thanks!

pedroferreira1 · 2024-08-30T21:15:42Z

src/components/WalletConnect/SignOracleDataRequest.js

+  const navigation = useNavigation();
+
+  const onAcceptSignOracleDataRequest = () => {
+    const acceptedNc = { address, message };


acceptedData?

Done! Thanks

Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]>

Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]>

…ed acceptedNc to acceptedData

* chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enable walletconnect by default (#541) * feat: implement Nano Contract integration with Wallet Connect * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * chore: changed CI version to 18x and 20x * refactor: enabled walletconnect by default * chore: updated package-lock * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * refactor: ignore confirmation modal (#544) * refactor: ignore modal confirmation screen * refactor: added a config to skip walletconnect confirmation modals * feat: skip confirmation modal on sign message modal as well --------- Co-authored-by: Alex Ruzenhack <[email protected]> * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * chore: added dependencies and shims needed by walletconnect * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * refactor: enabled walletconnect by default * chore: updated walletconnect dependencies to be equal to the patch * refactor: default network is nano testnet (#542) * chore: add undeclared style * refactor: rename effect requestTokens to requestUnregisteredTokens * feat: fire sentry error notification for method info not found * feat: improve title of Arguments component * refactor: reanem style value to field * fix: FeedbackContent margin style Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative. * lint: comply with rules * fix: typo * refactor: using object destructuring in shims * refactor: typo * refactor: removed unused import on NanoContactTransactionHeader * chore: removed walletconnect libraries from package * feat: added hathor-rpc-handler from the deployed lib * refactor: enabled walletconnect by default * refactor: added nano testnet as default network * feat: allow the user to select the nano testnet in network settings * refactor: removed walletservice urls from constants on nano testnet * refactor: remove nc status from tx details (#546) * refactor: remove nc status from tx details * feat: add status label for voided tx * feat: add event coin token as default alongside with hathor (#547) * feat: add register nano contract buttom if nc not registered on new nc transaction (#545) * feat: add register nano contract buttom if nc not registered on new nc transaction * feat: add failure feedback modal for Nano Contract registration failure * feat: restore ready state of nano contract registration also in the success path * refactor: skip directly to the ChoosePinScreen (#543) * refactor: skip directly to the ChoosePinScreen * refactor: added a constant to determine whether to show the confirmation screen * refactor: default skip_seed_confirmation to true --------- Co-authored-by: Alex Ruzenhack <[email protected]> * feat: added sign oracle data request component and screen * refactor: removed onReadMore * refactor: skip confirmation on sign oracle data * refactor: stop sending baseStyles to sign oracle request and refactored acceptedNc to acceptedData --------- Co-authored-by: Alex Ruzenhack <[email protected]>

andreabadesso requested a review from pedroferreira1 as a code owner July 16, 2024 16:30

andreabadesso self-assigned this Jul 16, 2024

andreabadesso added the enhancement New feature or request label Jul 16, 2024

alexruzenhack force-pushed the feat/rpc-lib-integration branch from 72be982 to 56059a2 Compare July 18, 2024 14:48

andreabadesso force-pushed the feat/rpc-lib-integration branch 3 times, most recently from 8eb54d9 to 3f087ab Compare August 21, 2024 00:30

andreabadesso force-pushed the feat/sign-oracle-data branch from d690160 to 9e37b68 Compare August 28, 2024 21:53

andreabadesso changed the base branch from feat/rpc-lib-integration to refactor/default-network August 28, 2024 21:53

andreabadesso force-pushed the feat/sign-oracle-data branch from 9e37b68 to 4ff8ff1 Compare August 29, 2024 15:52

andreabadesso force-pushed the refactor/default-network branch 3 times, most recently from fb46e71 to 8a4734f Compare August 29, 2024 16:57

andreabadesso changed the base branch from refactor/default-network to refactor/enable-walletconnect August 29, 2024 17:17

andreabadesso force-pushed the feat/sign-oracle-data branch 3 times, most recently from d66dabb to e986904 Compare August 29, 2024 18:18

andreabadesso changed the base branch from refactor/enable-walletconnect to hathorplay-base August 29, 2024 18:18

andreabadesso force-pushed the feat/sign-oracle-data branch from e986904 to a9ebeca Compare August 29, 2024 18:19

pedroferreira1 approved these changes Aug 30, 2024

View reviewed changes

andreabadesso force-pushed the hathorplay-base branch 2 times, most recently from 8ea51df to 0b3ff99 Compare August 31, 2024 21:16

alexruzenhack added 8 commits August 31, 2024 18:17

chore: add undeclared style

25ec57f

refactor: rename effect requestTokens to requestUnregisteredTokens

70e4bf3

feat: fire sentry error notification for method info not found

f6ebcd3

feat: improve title of Arguments component

464bfd7

refactor: reanem style value to field

1ee2008

fix: FeedbackContent margin style

5ac7aca

Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

lint: comply with rules

f7224b2

fix: typo

7ad484a

andreabadesso and others added 25 commits August 31, 2024 18:26

chore: added dependencies and shims needed by walletconnect

aaed363

refactor: using object destructuring in shims

99b3bfa

refactor: typo

656347a

refactor: removed unused import on NanoContactTransactionHeader

7cc8480

chore: removed walletconnect libraries from package

76b9ff5

chore: add undeclared style

6d299e1

refactor: rename effect requestTokens to requestUnregisteredTokens

b94abf6

feat: fire sentry error notification for method info not found

6e6c031

feat: improve title of Arguments component

70b20aa

refactor: reanem style value to field

32793bf

fix: FeedbackContent margin style

bf6260b

Remarks: The `marginVertical` and `marginHorizontal` are not being applied. Probably this is a bug in ReactNative.

lint: comply with rules

0c2f444

fix: typo

2b173ee

chore: added dependencies and shims needed by walletconnect

c2028f5

refactor: using object destructuring in shims

90c50c9

refactor: typo

5d60366

refactor: removed unused import on NanoContactTransactionHeader

72c1f0d

chore: removed walletconnect libraries from package

4d8e072

refactor: enabled walletconnect by default

59ec326

chore: updated walletconnect dependencies to be equal to the patch

a225329

feat: added sign oracle data request component and screen

b551608

refactor: removed onReadMore

61ba28d

refactor: skip confirmation on sign oracle data

63992a4

andreabadesso force-pushed the feat/sign-oracle-data branch from a9ebeca to 63992a4 Compare August 31, 2024 21:29

refactor: stop sending baseStyles to sign oracle request and refactor…

1c7a9bc

…ed acceptedNc to acceptedData

andreabadesso merged commit a429e3e into hathorplay-base Aug 31, 2024

andreabadesso deleted the feat/sign-oracle-data branch August 31, 2024 21:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: sign oracle data #509

feat: sign oracle data #509

Uh oh!

andreabadesso commented Jul 16, 2024 •

edited

Loading

Uh oh!

pedroferreira1 Aug 30, 2024

Uh oh!

andreabadesso Aug 31, 2024

Uh oh!

pedroferreira1 Aug 30, 2024

Uh oh!

andreabadesso Aug 31, 2024

Uh oh!

Uh oh!

feat: sign oracle data #509

feat: sign oracle data #509

Uh oh!

Conversation

andreabadesso commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Acceptance Criteria

Security Checklist

Uh oh!

pedroferreira1 Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

andreabadesso Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

pedroferreira1 Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

andreabadesso Aug 31, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andreabadesso commented Jul 16, 2024 •

edited

Loading