Integration Tests: balance, tx-history, address-info and transaction routes #149
Conversation
pending: include a miner
|
This pull request introduces 1 alert when merging b1b6637 into fd1ebaa - view on LGTM.com new alerts:
|
|
This pull request fixes 1 alert when merging c0f84c5 into fd1ebaa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 97840f3 into fd1ebaa - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## dev #149 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 7 7
Lines 464 464
Branches 103 103
=======================================
Hits 376 376
Misses 80 80
Partials 8 8 Continue to review full report at Codecov.
|
tuliomir
changed the title
|
This pull request fixes 1 alert when merging 080bc76 into fd1ebaa - view on LGTM.com fixed alerts:
|
| } | ||
|
|
||
| // Log the success and return | ||
| loggers.test.informNewWallet(walletObj.walletId, walletObj.words) |
There was a problem hiding this comment.
Why don't you catch all errors on the insertLineToLog method, and log them?
Co-authored-by: André Abadesso <[email protected]>
Co-authored-by: André Abadesso <[email protected]>
Note: When on Github, the config "outputFolder" property should match the one specified on the integration-test.yml workflow. Otherwise, the test artifacts will not be correctly uploaded
This pull request is the first phase of the implementation of Integration Tests on the Hathor Wallet Headless, and lays the foundation for easily expanding the test scenarios in the future.
In short, on each PR the Github Actions were configured to run a
docker-composestarting a Hathor private network, as described in the private network guide, and then runs a series of tests on this network, validating the integration between the wallet and the network as a whole.Acceptance Criteria
/wallet/transaction/wallet/address-info/wallet/tx-history/wallet/balancedevandmasterbranchesSecurity Checklist