-
Notifications
You must be signed in to change notification settings - Fork 25
Integration tests: simple send-tx, send-tx, create-tokens, mint and melt tokens #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #152 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 7 7
Lines 464 464
Branches 103 103
=======================================
Hits 376 376
Misses 80 80
Partials 8 8 Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 9416f88 into a8151b2 - view on LGTM.com new alerts:
|
This operation should be explicit whenever an operation to get balance is to be done.
These todos should be reviewed together with the skipped tests on a future issue
also, they are now editable via environment variables
This pull request is the second phase of the implementation of Integration Tests on the Hathow Wallet Headless, and expands the scope of #149 .
Changes on previous tests:
WalletHelper.startMultipleWalletsForTest()
method. This is a performance improvement, since wallet initialization is the most time-consuming process on the integration tests.setupTests-integration.js:beforeAll()
method to use the process above.An effort was made to make the tests use as little transactions as possible, since transactions are the second slowest process on the tests. As the integration tests use Jest's
--runInBand
configuration, it became possible to use one test's resulting condition as precondition to the next tests.Sometimes this may compromise the readability of the testing code, but it was a tradeoff for performance.
Acceptance Criteria
/wallet/simple-send
/wallet/send-tx
/wallet/create-tokens
/wallet/mint-tokens
/wallet/melt-tokens
Security Checklist