fix: lgtm raised issues

Author: tuliomir

__tests__/integration/poc.test.js

@@ -33,7 +33,7 @@ describe.skip("proof of concept tests", () => {
   it('should make a transaction from genesis address to second wallet', async done => {
     // Transfer 1.01 HTR to the second wallet
     const transactionAmount = 101;
-    const transfer = await TestUtils.request
+    await TestUtils.request
       .post('/wallet/simple-send-tx')
       .send({
         address: WALLET_CONSTANTS.second.addresses[0],

jest-integration.config.js

@@ -1,11 +1,10 @@
 module.exports = {
   clearMocks: true,
-  coverageDirectory: "coverage",
+  coverageDirectory: "coverage-integration",
   testEnvironment: "node",
   collectCoverage: true,
   collectCoverageFrom: ["<rootDir>/src/**/*.js"],
   testMatch: ["<rootDir>/__tests__/integration/**/*.test.js"],
-  coverageDirectory: "coverage",
   coverageReporters: ["text-summary", "lcov", "clover"],
   testTimeout: 20 * 60 * 1000, // 20 minutes seems reasonable for slow integration tests. May be adjusted with optimizations
   setupFilesAfterEnv: ["<rootDir>/setupTests-integration.js"],

jest.config.js

@@ -5,7 +5,6 @@ module.exports = {
   collectCoverage: true,
   collectCoverageFrom: ["<rootDir>/src/**/*.js"],
   testMatch: ["<rootDir>/__tests__/**/*.test.js"],
-  coverageDirectory: "coverage",
   coverageReporters: ["text-summary", "lcov", "clover"],
   testTimeout: 180000,
   setupFilesAfterEnv: ["<rootDir>/setupTests.js"],

package.json

@@ -20,7 +20,7 @@
     "test": "jest",
     "test_integration": "npm run test_network_up && npm run test_network_integration && npm run test_network_down",
     "test_network_up": "docker-compose -f ./__tests__/integration/docker-compose.yml up -d",
-    "test_network_integration": "jest --config jest-integration.config.js --runInBand",
+    "test_network_integration": "jest --config jest-integration.config.js --runInBand --forceExit",
     "test_network_down": "docker-compose -f ./__tests__/integration/docker-compose.yml down",
     "dev": "nodemon --exec babel-node index.js",
     "start": "babel-node src/index.js",