refactor: we should expect one output for each data instead of an array of data outputs #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
commented
Mar 20, 2025
| type?: string; | ||
| data?: string[]; | ||
| }>, | ||
| outputs: preparedTx.outputs, |
There was a problem hiding this comment.
This was a bug, we were always sending params.outputs, so we change output would never reach our client to review
andreabadesso
changed the title
andreabadesso
force-pushed
the
feat/one-output-per-data
branch
from
65707c1 to
aeda3c6
Compare
pedroferreira1
approved these changes
Mar 20, 2025
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
r4mmer
reviewed
Mar 24, 2025
| @@ -61,6 +61,11 @@ describe('sendTransaction', () => { | |||
| address: 'testAddress', | |||
| token: '00', | |||
| }], | |||
| outputs: [{ | |||
| address: 'testAddress', | |||
| value: BigInt(100), | |||
There was a problem hiding this comment.
Shouldn't all values be bigint? Should we change the input value as well?
There was a problem hiding this comment.
Yes we should, done
| @@ -61,6 +61,11 @@ describe('sendTransaction', () => { | |||
| address: 'testAddress', | |||
| token: '00', | |||
| }], | |||
| outputs: [{ | |||
| address: 'testAddress', | |||
| value: BigInt(100), | |||
There was a problem hiding this comment.
Refactored everywhere to use n instead of BigInt
andreabadesso
force-pushed
the
feat/one-output-per-data
branch
from
6d8f3e4 to
76d2f94
Compare
andreabadesso
force-pushed
the
feat/bigint-support
branch
from
2a8db7a to
791fd97
Compare
r4mmer
approved these changes
Mar 27, 2025
github-project-automation
bot
moved this from In Progress (WIP)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged