refactor: stop accepting an string array as data

Author: andreabadesso

packages/hathor-rpc-handler/__tests__/rpcMethods/sendTransaction.test.ts

@@ -132,7 +132,7 @@ describe('sendTransaction', () => {
     rpcRequest.params.outputs = [{
       type: 'data',
       value: '100',
-      data: ['test data'],
+      data: 'test data',
     }];
 
     promptHandler
@@ -163,53 +163,6 @@ describe('sendTransaction', () => {
     );
   });
 
-  it('should split multiple data items into separate outputs', async () => {
-    rpcRequest.params.outputs = [{
-      type: 'data',
-      value: '100',
-      data: ['data item 1', 'data item 2', 'data item 3'],
-    }];
-
-    promptHandler
-      .mockResolvedValueOnce({
-        type: TriggerResponseTypes.SendTransactionConfirmationResponse,
-        data: { accepted: true },
-      })
-      .mockResolvedValueOnce({
-        type: TriggerResponseTypes.PinRequestResponse,
-        data: { accepted: true, pinCode: '1234' },
-      });
-
-    sendTransactionMock.mockResolvedValue({ hash: 'txHash123' });
-
-    await sendTransaction(rpcRequest, wallet, {}, promptHandler);
-
-    // Verify each data item was transformed into a separate output
-    expect(wallet.sendManyOutputsSendTransaction).toHaveBeenCalledWith(
-      expect.arrayContaining([
-        expect.objectContaining({
-          type: 'data',
-          value: BigInt(1),
-          token: '00',
-          data: 'data item 1',
-        }),
-        expect.objectContaining({
-          type: 'data',
-          value: BigInt(1),
-          token: '00',
-          data: 'data item 2',
-        }),
-        expect.objectContaining({
-          type: 'data',
-          value: BigInt(1),
-          token: '00',
-          data: 'data item 3',
-        }),
-      ]),
-      expect.any(Object),
-    );
-  });
-
   it('should handle mix of data and regular outputs correctly', async () => {
     rpcRequest.params.outputs = [
       {
@@ -219,7 +172,7 @@ describe('sendTransaction', () => {
       },
       {
         type: 'data',
-        data: ['data item 1', 'data item 2'],
+        data: 'data item',
         value: '1',
       },
       {
@@ -243,7 +196,7 @@ describe('sendTransaction', () => {
 
     await sendTransaction(rpcRequest, wallet, {}, promptHandler);
 
-    // Verify the transformation preserves regular outputs and splits data outputs
+    // Verify the transformation preserves regular outputs and handles data output
     expect(wallet.sendManyOutputsSendTransaction).toHaveBeenCalledWith(
       expect.arrayContaining([
         expect.objectContaining({
@@ -255,13 +208,7 @@ describe('sendTransaction', () => {
           type: 'data',
           value: BigInt(1),
           token: '00',
-          data: 'data item 1',
-        }),
-        expect.objectContaining({
-          type: 'data',
-          value: BigInt(1),
-          token: '00',
-          data: 'data item 2',
+          data: 'data item',
         }),
         expect.objectContaining({
           address: 'testAddress2',
@@ -272,8 +219,8 @@ describe('sendTransaction', () => {
       expect.any(Object),
     );
 
-    // Verify the array length matches the expected number of outputs (2 regular + 2 data outputs)
-    expect(wallet.sendManyOutputsSendTransaction.mock.calls[0][0]).toHaveLength(4);
+    // Verify the array length matches the expected number of outputs (2 regular + 1 data output)
+    expect(wallet.sendManyOutputsSendTransaction.mock.calls[0][0]).toHaveLength(3);
   });
 
   it('should throw InvalidParamsError for invalid request parameters', async () => {

packages/hathor-rpc-handler/src/rpcMethods/sendTransaction.ts

@@ -42,7 +42,7 @@ const sendTransactionSchema = z.object({
         .optional(),
       token: z.string().optional(),
       type: z.string().optional(),
-      data: z.array(z.string()).optional(),
+      data: z.string().optional(),
     })
     .transform(output => {
       // If data is present, automatically set type to 'data'
@@ -58,7 +58,7 @@ const sendTransactionSchema = z.object({
       }
       return true;
     }, {
-      message: "Value is required when data is not provided"
+      message: 'Value is required when data is not provided'
     })).min(1),
     inputs: z.array(z.object({
       txId: z.string(),
@@ -105,18 +105,18 @@ export async function sendTransaction(
     value?: bigint;
     token?: string;
     type?: string;
-    data?: string | string[];
+    data?: string;
   }>>((acc, output) => {
     const result = { ...output };
 
-    // Each data should be a data output spending 0.01 HTR
-    if (result.type === 'data' || (result.data && result.data.length > 0)) {
-      return [...acc, ...(result.data ? result.data.map((data) => ({
+    // We should manually set the 0.01 HTR to data output
+    // so it's displayed to the user during confirmation.
+    if (result.type === 'data') {
+      return [...acc, {
         ...output,
         value: 1n,
         token: constants.NATIVE_TOKEN_UID,
-        data,
-      })) : [])];
+      }];
     }
 
     return [...acc, result];

packages/hathor-rpc-handler/src/types/rpcRequest.ts

@@ -114,7 +114,7 @@ export interface SendTransactionRpcRequest {
       value: string | number | bigint;
       token?: string;
       type?: string;
-      data?: string[];
+      data?: string;
     }>;
     inputs?: Array<{
       txId: string;