Skip to content

refactor: we should expect one output for each data instead of an array of data outputs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f162520
feat: added sendtransaction method and types
andreabadesso Feb 12, 2025
0b1a2e5
feat: send transaction rpc method, validation and lib update
andreabadesso Feb 24, 2025
4eacc1e
refactor: removed unused console.log
andreabadesso Feb 24, 2025
4583529
tests: added tests for sendtransaction
andreabadesso Feb 24, 2025
b2f9b5f
refactor: removed invalid cast
andreabadesso Feb 24, 2025
93cb6b5
refactor: revert to correct version and package name
andreabadesso Feb 24, 2025
9362675
docs: better comments on pin mock
andreabadesso Mar 6, 2025
cd77135
chore: removed unused import
andreabadesso Mar 6, 2025
1d56a1b
chore: added missing deps
andreabadesso Mar 6, 2025
8d7166c
chore: removed long and added zod
andreabadesso Mar 6, 2025
0012362
refactor: we should not add 0.01 htr automatically when data output
andreabadesso Mar 7, 2025
b5879f0
refactor: revert to manually adding 1 HTR to data outputs
andreabadesso Mar 7, 2025
30a775e
feat: sending specific error for failure in prepare tx
andreabadesso Mar 13, 2025
c2df73d
fix: create token rpc should accept strings and output bigint
andreabadesso Mar 14, 2025
a86e8c0
feat: transforming amount in sendNanoContractTx to bigint
andreabadesso Mar 17, 2025
d9fe22f
tests: added tests for bigint transformations
andreabadesso Mar 17, 2025
a408025
Merge branch 'master' into feat/bigint-support
andreabadesso Mar 17, 2025
8e274f4
refactor: using coerse to transform to bigint
andreabadesso Mar 17, 2025
154880f
refactor: we should reject zero values for send nano contract tx amount
andreabadesso Mar 20, 2025
ac11418
refactor: sendTransaction should expect only positive values for outputs
andreabadesso Mar 20, 2025
791fd97
refactor: custom zod schema for NanoContractActionSchema
andreabadesso Mar 26, 2025
2a8db7a
refactor: BigInt -> n
andreabadesso Mar 27, 2025
972f504
feat: splitting data outputs into multiple outputs
andreabadesso Mar 20, 2025
8822505
test: add tests for data output splitting functionality
andreabadesso Mar 20, 2025
76d2f94
refactor: stop accepting an string array as data
andreabadesso Mar 20, 2025
110e593
Merge branch 'master' into feat/one-output-per-data
andreabadesso Apr 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,20 @@ describe('createToken', () => {
rpcRequest = {
method: RpcMethods.CreateToken,
params: {
name: 'mytoken',
symbol: 'mtk',
amount: 1000,
address: 'address123',
change_address: 'changeAddress123',
name: 'Test Token',
symbol: 'TT',
amount: '100',
address: 'wallet1',
change_address: 'wallet1',
create_mint: true,
mint_authority_address: null,
mint_authority_address: 'wallet1',
allow_external_mint_authority_address: false,
create_melt: true,
melt_authority_address: null,
melt_authority_address: 'wallet1',
allow_external_melt_authority_address: false,
data: null,
push_tx: true,
network: 'mainnet',
network: 'testnet',
data: ['test'],
},
} as unknown as CreateTokenRpcRequest;

Expand Down Expand Up @@ -93,7 +93,9 @@ describe('createToken', () => {
{
type: TriggerTypes.CreateTokenConfirmationPrompt,
method: rpcRequest.method,
data: toCamelCase(rpcRequest.params),
data: expect.objectContaining({
amount: BigInt(rpcRequest.params.amount),
}),
},
{}
);
Expand All @@ -108,7 +110,7 @@ describe('createToken', () => {
expect(wallet.createNewToken).toHaveBeenCalledWith(
rpcRequest.params.name,
rpcRequest.params.symbol,
rpcRequest.params.amount,
BigInt(rpcRequest.params.amount),
{
...toCamelCase(rpcRequest.params),
amount: undefined,
Expand Down Expand Up @@ -137,7 +139,11 @@ describe('createToken', () => {
{
type: TriggerTypes.CreateTokenConfirmationPrompt,
method: rpcRequest.method,
data: toCamelCase(rpcRequest.params),
data: expect.objectContaining({
amount: BigInt(rpcRequest.params.amount),
name: rpcRequest.params.name,
symbol: rpcRequest.params.symbol,
}),
},
{}
);
Expand Down Expand Up @@ -174,7 +180,7 @@ describe('createToken', () => {

await expect(createToken(rpcRequest, wallet, {}, triggerHandler)).rejects.toThrow(Error);

expect(wallet.isAddressMine).toHaveBeenCalledWith('changeAddress123');
expect(wallet.isAddressMine).toHaveBeenCalledWith('wallet1');
});

describe('parameter validation', () => {
Expand All @@ -190,8 +196,8 @@ describe('createToken', () => {
const invalidRequest = {
method: RpcMethods.CreateToken,
params: {
symbol: 'MTK',
amount: 1000,
symbol: 'TT',
amount: '100',
// name is missing
},
} as CreateTokenRpcRequest;
Expand All @@ -204,9 +210,9 @@ describe('createToken', () => {
const invalidRequest = {
method: RpcMethods.CreateToken,
params: {
name: 'My Token',
symbol: 'MTK',
amount: 0,
name: 'Test Token',
symbol: 'TT',
amount: '0',
},
} as CreateTokenRpcRequest;

Expand All @@ -218,9 +224,9 @@ describe('createToken', () => {
const invalidRequest = {
method: RpcMethods.CreateToken,
params: {
name: 'My Token',
symbol: 'MTK',
amount: '1000' as unknown as number,
name: 'Test Token',
symbol: 'TT',
amount: 100 as unknown as string,
},
} as CreateTokenRpcRequest;

Expand All @@ -232,9 +238,9 @@ describe('createToken', () => {
const invalidRequest = {
method: RpcMethods.CreateToken,
params: {
name: 'My Token',
symbol: 'MTK',
amount: 1000,
name: 'Test Token',
symbol: 'TT',
amount: '100',
create_mint: 'yes' as unknown as boolean,
},
} as CreateTokenRpcRequest;
Expand All @@ -248,8 +254,8 @@ describe('createToken', () => {
method: RpcMethods.CreateToken,
params: {
name: '',
symbol: 'MTK',
amount: 1000,
symbol: 'TT',
amount: '100',
},
} as CreateTokenRpcRequest;

Expand Down
Loading