-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(mypy): add stricter rules to p2p tests [part IV/VI] #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce34601
to
21bdd94
Compare
bb8ad15
to
5318232
Compare
21bdd94
to
6e1595f
Compare
5318232
to
5235577
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 85.06% 85.10% +0.04%
==========================================
Files 294 294
Lines 22800 22801 +1
Branches 3435 3435
==========================================
+ Hits 19394 19405 +11
+ Misses 2720 2713 -7
+ Partials 686 683 -3 ☔ View full report in Codecov by Sentry. |
1 task
5235577
to
ef291c0
Compare
1 task
msbrogli
previously approved these changes
Mar 19, 2024
6e1595f
to
2bea84c
Compare
ef291c0
to
1a1d5c8
Compare
jansegre
reviewed
Mar 19, 2024
2bea84c
to
639d981
Compare
1a1d5c8
to
59fb234
Compare
639d981
to
5b95253
Compare
1f362af
to
20d492d
Compare
jansegre
previously approved these changes
Mar 20, 2024
20d492d
to
56ac0ba
Compare
msbrogli
approved these changes
Mar 21, 2024
jansegre
approved these changes
Mar 21, 2024
20a973d
to
b42aa67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #972
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the first PR in this series, #969.
Acceptance Criteria
tests.p2p
module and update it to conform.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged