review changes

Author: glevco

tests/p2p/test_get_best_blockchain.py

@@ -279,6 +279,7 @@ def test_best_blockchain_from_storage(self) -> None:
 
         # cache miss if best block doesn't match
         fake_block = HeightInfo(1, b'fake hash')
+        # manager1._latest_n_height_tips = [fake_block]  # FIXME: This property is not defined. Fix this test.
         best_blockchain = manager1.tx_storage.get_n_height_tips(1)  # there is only the genesis block
         block = best_blockchain[0]
         # the memoized best_blockchain is skiped

tests/p2p/test_split_brain.py

@@ -29,6 +29,7 @@ def create_peer(self, network: str, unlock_wallet: bool = True) -> HathorManager
 
         manager = super().create_peer(network, wallet=wallet)
         manager.daa.TEST_MODE = TestMode.TEST_ALL_WEIGHT
+        # manager.avg_time_between_blocks = 64  # FIXME: This property is not defined. Fix this test.
 
         # Don't use it anywhere else. It is unsafe to generate mnemonic words like this.
         # It should be used only for testing purposes.
@@ -42,8 +43,10 @@ def test_split_brain_plain(self) -> None:
         debug_pdf = False
 
         manager1 = self.create_peer(self.network, unlock_wallet=True)
+        # manager1.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         manager2 = self.create_peer(self.network, unlock_wallet=True)
+        # manager2.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         for _ in range(10):
             add_new_block(manager1, advance_clock=1)
@@ -101,8 +104,10 @@ def test_split_brain_plain(self) -> None:
     @pytest.mark.slow
     def test_split_brain_only_blocks_different_height(self) -> None:
         manager1 = self.create_peer(self.network, unlock_wallet=True)
+        # manager1.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         manager2 = self.create_peer(self.network, unlock_wallet=True)
+        # manager2.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         for _ in range(10):
             add_new_block(manager1, advance_clock=1)
@@ -144,8 +149,10 @@ def test_split_brain_only_blocks_different_height(self) -> None:
     # For now we are voiding everyone until the first common block
     def test_split_brain_only_blocks_same_height(self) -> None:
         manager1 = self.create_peer(self.network, unlock_wallet=True)
+        # manager1.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         manager2 = self.create_peer(self.network, unlock_wallet=True)
+        # manager2.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         for _ in range(10):
             add_new_block(manager1, advance_clock=1)
@@ -265,8 +272,10 @@ def test_split_brain_only_blocks_same_height(self) -> None:
 
     def test_split_brain_only_blocks_bigger_score(self) -> None:
         manager1 = self.create_peer(self.network, unlock_wallet=True)
+        # manager1.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         manager2 = self.create_peer(self.network, unlock_wallet=True)
+        # manager2.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
 
         # Start with 1 because of the genesis block
         manager2_blocks = 1
@@ -323,9 +332,11 @@ def test_split_brain_only_blocks_bigger_score(self) -> None:
 
     def test_split_brain_no_double_spending(self) -> None:
         manager1 = self.create_peer(self.network, unlock_wallet=True)
+        # manager1.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
         manager1.connections.disable_rate_limiter()
 
         manager2 = self.create_peer(self.network, unlock_wallet=True)
+        # manager2.avg_time_between_blocks = 3  # FIXME: This property is not defined. Fix this test.
         manager2.connections.disable_rate_limiter()
 
         winner_blocks = 1