refactor(mypy): add stricter rules to more test modules [part III/VI] #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
4469614 to
59dba5c
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
ce34601 to
21bdd94
Compare
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
59dba5c to
7fb6b30
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
21bdd94 to
6e1595f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 85.05% 85.07% +0.02%
==========================================
Files 294 294
Lines 22798 22798
Branches 3434 3434
==========================================
+ Hits 19391 19396 +5
+ Misses 2720 2714 -6
- Partials 687 688 +1 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
msbrogli
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-2
branch
2 times, most recently
from
eea7f83 to
0fafa35
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
6e1595f to
2bea84c
Compare
jansegre
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
0fafa35 to
6613e62
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
2bea84c to
639d981
Compare
glevco
force-pushed
the
refactor/strict-mypy-2
branch
2 times, most recently
from
189f48c to
a9219d6
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
639d981 to
5b95253
Compare
msbrogli
approved these changes
Mar 20, 2024
jansegre
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #971
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the first PR in this series, #969.
Acceptance Criteria
tests.simulationmodule and update it to conform.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged