feat: upgrade all instances of PHP 7.4 and 8.0 to 8.1 or higher #1963
Conversation
product-auto-label
bot
added
the
samples
| @@ -90,7 +90,7 @@ function update_app_profile( | |||
| if ($operationResponse->operationSucceeded()) { | |||
| $updatedAppProfile = $operationResponse->getResult(); | |||
| printf('App profile updated: %s' . PHP_EOL, $updatedAppProfile->getName()); | |||
| // doSomethingWith($updatedAppProfile) | |||
| // doSomethingWith($updatedAppProfile) | |||
There was a problem hiding this comment.
Should we remove this line?
There was a problem hiding this comment.
I am ambivalent... someone put it here because they thought it illustrated something important. I only changed it because it was indented improperly.
| @@ -34,7 +34,7 @@ The application consists of three components: | |||
| 3. An [`index.php`](index.php) which handles all the requests which get routed to your app. | |||
|
|
|||
| The `index.php` file is the most important. All applications running on App Engine | |||
| for PHP 7.4 require use of a [front controller][front-controller] file. | |||
| for PHP require use of a [front controller][front-controller] file. | |||
There was a problem hiding this comment.
Why did we drop the version in these files?
I could see this being redundant though. Are the minimum requirements stated elsewhere?
There was a problem hiding this comment.
Because the instructions are not specific to a version of PHP, so we can remove the "7.4" because it's an unnecessary qualifier.
| @@ -90,7 +90,7 @@ function update_app_profile( | |||
| if ($operationResponse->operationSucceeded()) { | |||
| $updatedAppProfile = $operationResponse->getResult(); | |||
| printf('App profile updated: %s' . PHP_EOL, $updatedAppProfile->getName()); | |||
| // doSomethingWith($updatedAppProfile) | |||
| // doSomethingWith($updatedAppProfile) | |||
| } else { | |||
| $error = $operationResponse->getError(); | |||
| // handleError($error) | |||
There was a problem hiding this comment.
Same with this one - the comment is meant as an example of something a user could implement, e.g. they could implement some error handling here with a fake function such as handleError
|
Looks like the |
addresses #1962 and #1961
see cl/634137632