-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: upgrade all instances of PHP 7.4 and 8.0 to 8.1 or higher #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
a0a14fc
28a4717
6cc3d24
5f3fec7
a4a8b89
7637e9f
4d8dc59
991740c
a056681
b6994c2
2e96bb8
afd06ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# Getting Started on App Engine for PHP 7.4 | ||
# Getting Started on App Engine for PHP 8.1 | ||
|
||
This sample demonstrates how to deploy a PHP application which integrates with | ||
Cloud SQL and Cloud Storage on App Engine Standard for PHP 7.4. The tutorial | ||
Cloud SQL and Cloud Storage on App Engine Standard for PHP 8.1. The tutorial | ||
uses the Slim framework. | ||
|
||
## View the [full tutorial](https://cloud.google.com/appengine/docs/standard/php7/building-app/) | ||
## View the [full tutorial](https://cloud.google.com/appengine/docs/standard/php-gen2/building-app) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ function update_app_profile( | |
if ($operationResponse->operationSucceeded()) { | ||
$updatedAppProfile = $operationResponse->getResult(); | ||
printf('App profile updated: %s' . PHP_EOL, $updatedAppProfile->getName()); | ||
// doSomethingWith($updatedAppProfile) | ||
// doSomethingWith($updatedAppProfile) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we remove this line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am ambivalent... someone put it here because they thought it illustrated something important. I only changed it because it was indented improperly. |
||
} else { | ||
$error = $operationResponse->getError(); | ||
// handleError($error) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same with this one - the comment is meant as an example of something a user could implement, e.g. they could implement some error handling here with a fake function such as |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"require": { | ||
"php": ">= 7.4", | ||
"php": ">= 8.1", | ||
"google/cloud-functions-framework": "^1.1" | ||
}, | ||
"scripts": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"require": { | ||
"php": ">= 7.4", | ||
"php": ">= 8.1", | ||
"google/cloud-functions-framework": "^1.1" | ||
}, | ||
"scripts": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"require": { | ||
"php": ">= 7.4", | ||
"php": ">= 8.1", | ||
"google/cloud-functions-framework": "^1.3" | ||
}, | ||
"scripts": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we drop the version in these files?
I could see this being redundant though. Are the minimum requirements stated elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the instructions are not specific to a version of PHP, so we can remove the "7.4" because it's an unnecessary qualifier.