feat: remove php 8.0, add php 8.3 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hectorhammett
approved these changes
May 16, 2024
| @@ -1,6 +1,6 @@ | |||
| FROM gcr.io/gcp-runtimes/ubuntu_20_0_4 | |||
| ENV PHP_DIR=/opt/php82 | |||
| ENV PHP_SRC_DIR=/usr/local/src/php80-build | |||
| ENV PHP_SRC_DIR=/usr/local/src/php82-build | |||
There was a problem hiding this comment.
It's just the same of the env var (PHP_SRC_DIR) for the PHP source, so basically PHP 8.2 was being sourced in a directory called php80. It's not a functional problem, but I didn't like it, so I changed it.
|
@yoshi-approver anyone able to give this a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 is EOL, and PHP 8.3 was released over 6 months ago. We should remove the PHP 8 container and begin testing on PHP 8.3
See GoogleCloudPlatform/php-docs-samples#1963