chore(job): remove unused region tags #9969

alarconesparza · 2025-01-07T23:29:42Z

Description

Delete unused region tags from migration and deletion processes related with BasicCompanySample.java

Fixes
Internal
b/347826075
b/347826038
b/347826042
b/347826020
b/347351874
b/347351606
b/347351980
b/347351405

Checklist

ghost

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request removes unused region tags from the BasicCompanySample.java file within the jobs/v3 directory. The intent is to clean up the codebase and improve readability. Specifically, the following changes were made:

Removed region tags: The pull request systematically removes several instances of // [START ...] and // [END ...] comments that were previously used to delineate code sections. These appear to be obsolete and no longer necessary.

Here's a breakdown of the affected lines in BasicCompanySample.java:

File Location	Removed Lines (Approximate)
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	Lines 49-50, 64-65, 87-88, 105-106, 132-133, 160-161, 175-176

The pull request also addresses several internal bug fixes (b/347826075, b/347826038, b/347826042, b/347826020, b/347351874, b/347351606, b/347351980). The author, alarconesparza, has indicated that all tests and lint checks pass.

I'll be looking at the code more thoroughly to ensure the removal of these region tags doesn't introduce any unintended side effects or break existing functionality. I'll also verify the fix for the listed bugs.

And now, a little haiku to lighten the mood:

Tags removed with care,
Code now clean, a sight to see,
Review, then we merge.

ghost

This PR removes unused region tags, which is good for code clarity. The changes seem correct, but ensure the documentation reflects these changes. Also, double-check the affected code examples still function as expected after removing these tags.

snippet-bot · 2025-01-08T01:31:08Z

Here is the summary of changes.

You are about to delete 6 region tags.

jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:49, tag basic_company
jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:67, tag create_company
jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:91, tag get_company
jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:109, tag update_company
jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:136, tag update_company_with_field_mask
jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java:163, tag delete_company

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

ghost

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request removes unused region tags from the BasicCompanySample.java file within the jobs/v3 directory. The intent is to clean up the codebase and improve readability. Specifically, the following changes were made:

Removed unused region tags: The pull request systematically removes several instances of // [START ... ] and // [END ... ] comments that were no longer needed. These tags are commonly used for code snippets in documentation, but in this case, they were redundant.

Here's a table summarizing the affected lines:

File	Removed Start Tag Line	Removed End Tag Line
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	49	64
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	67	87
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	91	105
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	109	132
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	136	160
`jobs/v3/src/main/java/com/google/samples/BasicCompanySample.java`	163	175

The author, alarconesparza, has indicated that the changes address several internal issues (b/347826075, b/347826038, b/347826042, b/347826020, b/347351874, b/347351606, b/347351980) and that tests and lint checks have passed.

I'll be back soon with a full review.

Meanwhile, a little haiku to brighten your day:

Code flows like a stream,
Cleaning up, a gentle hand,
Clarity takes form.

ghost

This PR removes unused region tags, which is a good cleanup. The changes are straightforward and improve readability. The PR description is also well-written and informative.

ghost

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request removes unused region tags from the BasicCompanySample.java file within the jobs/v3 directory. The intent is to clean up the codebase and improve readability. Specifically, the following changes were made:

Removed unused region tags: The pull request systematically removes several instances of // [START ... ] and // [END ... ] comments that were not associated with any code blocks. These comments are used to delineate code snippets in the documentation, and removing unused ones improves the clarity of the code.

Here's a table summarizing the affected lines:

File	Lines Removed (approx.)	Description
`BasicCompanySample.java`	12	Removed unused region tags throughout the `BasicCompanySample` class.

The author, alarconesparza, has indicated that the changes address several internal issues (b/347826075, b/347826038, b/347826042, b/347826020, b/347351874, b/347351606, b/347351980). All tests and lint checks have passed.

And now, a little haiku to lighten the mood:

Tags removed with care,
Code now cleaner, bright, and new,
Review's swift and kind.

ghost

This PR removes redundant region tags, which improves code clarity. The changes are well-targeted and follow the sample format guide. The checklist is also appropriately filled.

ghost

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request removes unused region tags from the BasicCompanySample.java file within the jobs/v3 directory. The intent is to clean up the codebase and improve readability. Specifically, the following changes were made:

Removed unused region tags: The pull request systematically removes several instances of // [START ...] and // [END ...] comments that were not associated with any code sections. These comments are used in the Google Cloud documentation to delineate code snippets, but in this case, they were redundant.

Here's a table summarizing the affected lines:

File	Line Removed (Start)	Line Removed (End)	Description
`BasicCompanySample.java`	49	64	`basic_company` region tag
`BasicCompanySample.java`	67	67	`create_company` region tag
`BasicCompanySample.java`	87	87	`get_company` region tag
`BasicCompanySample.java`	109	109	`update_company` region tag
`BasicCompanySample.java`	136	136	`update_company_with_field_mask` region tag
`BasicCompanySample.java`	163	163	`delete_company` region tag

The pull request addresses several internal issues (b/347826075, b/347826038, b/347826042, b/347826020, b/347351874, b/347351606, b/347351980) and the author has indicated that all tests and lint checks have passed.

I'll be back soon with a more detailed review. Until then, enjoy this little poem:

Clean code, a joy to see,
No tags left, wild and free,
A coder's happy sigh.

Thanks,
Gemini

ghost

This PR removes redundant region tags, which improves code clarity. The changes are straightforward and beneficial. The checklist is also appropriately filled. Consider adding a brief comment explaining why the removed region tags were unused.

* chore(job): migrate regions by associating them with an official product with a job_ prefix (#9883) * chore(endpoints): delete region 'swagger' in endpoints/multiple-versions (#9857) * chore(endpoints): delete region swagger to openapi-v1.yaml * chore(endpoints): delete region swagger to openapi-v2.yaml * chore(job): delete sample jobs_java_dependencies_beta (#9810) * chore(job): delete sample jobs_java_dependencies_beta * chore(job): delete region_tab 'jobs_java_dependencies_beta' and update 'google-api-services-jobs' version * feat(compute): add compute disk regional replicated sample (#9697) * Implemented compute_disk_regional_replicated sample, created test * Fixed zone * Fixed test * Fixed test * Fixed disk size * Fixed code as requested in the comment * feat(compute): add compute disk start/stop replication samples (#9650) * Implemented compute_disk_start_replication and compute_disk_stop_replication samples, created tests * Fixed test * Deleted not related classes * Fixed lint issue * Increased timeout * Split samples for zonal location * Fixed code * Fixed code * Increased timeout * Increased timeout * feat(tpu): add tpu vm create spot sample. (#9610) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_spot sample, created test * changed zone * Changed zone * Fixed empty lines and tests, deleted cleanup method * Changed zone * Deleted redundant test class * Increased timeout * Fixed test * feat(tpu): add tpu vm create startup script sample. (#9612) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_startup_script sample, created test * Fixed tests and empty lines * Changed zone * Deleted redundant test classes * Increased timeout * Fixed code * feat(tpu): add tpu queued resources create/get/delete samples (#9613) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Fixed test * Fixed tests * Fixed error massage * Fixed typo * Fixed zone * Fixed test * Fixed code * Deleted commented imports * Fixed code as requested in comments * feat(tpu): add tpu queued resources create spot (#9615) Add a code sample for tpu_queued_resources_create_spot * chore: add translate dev team for translate samples (#9888) b/385243174 * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Create, Delete, List, Get) (#9743) * sample codes for event threat detection custom modules * addressed comments * addressed comments * addressed comments * addressed comments * fix(compute): fixed compute_reservation_create_shared sample and test to use mocked client (#9840) * Fixed sample and test to use mocked client * Fixed code as requested in the comments * feat(compute): add compute instance create replicated boot disk sample (#9735) * Implemented compute_instance_create_replicated_boot_disk sample, created test * Fixed test * Fixed code as requested in the comments * Fixed Util class * Fixed code * feat(compute): add compute consistency group stop replication (#9694) * Implemented compute_consistency_group_create and compute_consistency_group_delete samples, created test * Implemented compute_consistency_group_stop_replication sample * Implemented compute_consistency_group_stop_replication sample * Created test and added needed classes for testing * Fixed test * Moved clean up methods * Added clean up methods for reservations * Fixed clean up method * Fixed clean up method * Added timeout * Reverted not related changes * Reverted not related changes * Reverted not related changes * Reverted not related changes * Fixed code * Split samples for zonal location * Added comments for methods * Fixed comments * feat(secretmanager): add optional ttl to create secret sample (#9889) * feat(secretmanager): add optional ttl to create secret sample * nit: Update secretmanager/src/main/java/secretmanager/CreateSecret.java Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * fix(secretmanager): fix comment indentation to resolve linting issues --------- Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * feat(tpu): add tpu queued resources list sample (#9614) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_list sample, created test * Fixed test * Fixed tests, deleted cleanup method * Fixed test * Fixed imports * feat(compute): add compute disk create secondary regional sample (#9641) * Implemented compute_disk_create_secondary_regional. created test * Fixed test * Fixed test * Fixed test * Fixed zone * Fixed naming * Fixed spaces * Fixed code * Fixed indentations * Fixed variable * Fixed code * Added cleanup methods * Fixed lint issue * Fixed lint issue * Fixed test * Fixed code * Fixed code * Fixed code * Deleted duplicated assertion * feat(compute): add compute disk create secondary sample. (#9643) * Implemented compute_disk_create_secondary sample, created test * Fixed code * Fixed variable * Fixed code * Merged changes from main * Fixed lint issue * fix(storage): migrate old region all to storagetransfer_transfer_all step 1 (#9917) * fix(job): remove old region create_job (#9914) * feat(compute): attach/ remove snapshot schedule to disk (#9791) * Implemented compute_snapshot_schedule_attach sample, created test * Implemented compute_snapshot_schedule_remove sample, created test * Fixed code * Fixed code as requested in the comments * feat(compute): add compute consistency group clone sample (#9885) * Implemented compute_consistency_group_clone and compute_consistency_group_clone_regional_disk samples, created tests * Fixed naming * feat(compute): add compute instance attach regional disk force sample (#9730) * Implemented compute_instance_attach_regional_disk_force sample, created test * Added clean up method * Fixed comments and parameters * Test order deleted * Fixed code * Fixed code * Fixed code * Increased timeout * Increased timeout * Increased timeout * Fixed code * Fixed code * Fixed code * Fixed naming * feat(compute): add compute disk create secondary custom sample (#9644) * Implemented compute_disk_create_secondary_custom sample, created test * Fixed code * Fixed variable * Fixed code * Fixed whitespace * Fixed whitespace * feat(compute): add compute snapshot schedule create/get/edit/list/delete samples (#9742) * Implemented compute_snapshot_schedule_delete and compute_snapshot_schedule_create samples, created test * Fixed test * Added compute_snapshot_schedule_get sample, created test * Fixed naming * Implemented compute_snapshot_schedule_edit, created test * Fixed naming * Implemented compute_snapshot_schedule_list sample, created test * Cleaned resources * Cleaned resources * Cleaned resources * Cleaned resources * Fixed test * Added comment * Fixed tests * Fixed code * Fixed code as requested in the comments * feat(compute): add compute disk create with snapshot schedule (#9788) * Implemented compute_disk_create_with_snapshot_schedule sample, created test * Fixed code * Fixed code * Fixed test * Fixed code * Fixed code as requested in the comments * Fixed lint issue * Fixed lint issue * Deleted redundant code * feat(tpu): add tpu queued resources time bound sample. (#9617) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_time_bound sample, created test * Changed zone for tpu * Cleanup resources * Fixed tests * Fixed test * Fixed code as requested in the comments * Fixed code as requested in the comments * fix(job): delete old region tag update_job_with_field_mask (#9940) * feat(job): migrate region tags to include product prefix (#9966) * fix(endpoints): migrate all regions (#9943) * fix: disable flakybot reporting (#9968) * chore(job): remove unused region tags (#9969) * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Update, Get Eff, List Eff, List Desc, Validate) (#9912) * sample codes for event threat detection custom modules * fixed lint * addressed comments * lint fix * addressed comments --------- Co-authored-by: OremGLG <[email protected]> Co-authored-by: eapl.me <[email protected]> Co-authored-by: Тетяна Ягодська <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: lovenishs04 <[email protected]> Co-authored-by: alarconesparza <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> Co-authored-by: Brian Dorsey <[email protected]>

chore(job): remove unused region tags

65b135e

ghost reviewed Jan 7, 2025

View reviewed changes

product-auto-label bot added samples Issues that are directly related to samples. api: jobs Issues related to the Cloud Talent Solution Job Search API. labels Jan 7, 2025

ghost reviewed Jan 7, 2025

View reviewed changes

alarconesparza marked this pull request as ready for review January 8, 2025 01:31

alarconesparza requested review from yoshi-approver and a team as code owners January 8, 2025 01:31

blunderbuss-gcf bot assigned bourgeoisor Jan 8, 2025

ghost reviewed Jan 8, 2025

View reviewed changes

iennae approved these changes Jan 8, 2025

View reviewed changes

iennae merged commit 66ab30f into GoogleCloudPlatform:main Jan 8, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(job): remove unused region tags #9969

chore(job): remove unused region tags #9969

alarconesparza commented Jan 7, 2025 •

edited

Loading

ghost left a comment

ghost left a comment

snippet-bot bot commented Jan 8, 2025

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

chore(job): remove unused region tags #9969

chore(job): remove unused region tags #9969

Conversation

alarconesparza commented Jan 7, 2025 • edited Loading

Description

Checklist

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

snippet-bot bot commented Jan 8, 2025

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

alarconesparza commented Jan 7, 2025 •

edited

Loading