feat(compute): add compute snapshot schedule create/get/edit/list/delete samples #9742

TetyanaYahodska · 2024-11-27T14:48:22Z

Description

Documentation - https://cloud.google.com/compute/docs/disks/scheduled-snapshots?authuser=0#create_snapshot_schedule , https://cloud.google.com/compute/docs/disks/manage-snapshot-schedules?authuser=0#gcloud_3, https://cloud.google.com/compute/docs/disks/manage-snapshot-schedules?authuser=0#view_snapshot_schedules
Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

…edule_create samples, created test

snippet-bot · 2024-12-01T17:59:51Z

Here is the summary of changes.

You are about to add 5 region tags.

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java:19, tag compute_snapshot_schedule_create
compute/cloud-client/src/main/java/compute/snapshotschedule/DeleteSnapshotSchedule.java:19, tag compute_snapshot_schedule_delete
compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java:19, tag compute_snapshot_schedule_edit
compute/cloud-client/src/main/java/compute/snapshotschedule/GetSnapshotSchedule.java:19, tag compute_snapshot_schedule_get
compute/cloud-client/src/main/java/compute/snapshotschedule/ListSnapshotSchedules.java:19, tag compute_snapshot_schedule_list

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

iennae · 2024-12-18T01:11:57Z

@gemini review

Sita04 · 2024-12-18T09:49:44Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+    // https://cloud.google.com/compute/docs/disks/snapshots?authuser=0#selecting_a_storage_location
+    String storageLocation = "US";
+    // Determines what happens to your snapshots if the source disk is deleted.
+    String onSourceDiskDelete = "KEEP_AUTO_SNAPSHOTS";


Is there an enum that can be used here instead of the string literal?

Yes, we have this enum. Thank you! Fixed

Sita04 · 2024-12-18T09:52:49Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+    // Define the daily schedule.
+    // ResourcePolicyDailyCycle dailySchedule =
+    //         ResourcePolicyDailyCycle.newBuilder()
+    //                 .setDaysInCycle(1)  // Every day
+    //                 .setStartTime(startTime)
+    //                 .build();
+
+    // Define the weekly schedule.
+    // List<ResourcePolicyWeeklyCycleDayOfWeek> dayOfWeeks = new ArrayList<>();
+    // ResourcePolicyWeeklyCycleDayOfWeek tuesdaySchedule =
+    //         ResourcePolicyWeeklyCycleDayOfWeek.newBuilder()
+    //                 .setDay(ResourcePolicyWeeklyCycleDayOfWeek.Day.TUESDAY.toString())
+    //                 .setStartTime(startTime)
+    //                 .build();
+    // dayOfWeeks.add(tuesdaySchedule);
+    //
+    // ResourcePolicyWeeklyCycle weeklyCycle = ResourcePolicyWeeklyCycle.newBuilder()
+    //         .addAllDayOfWeeks(dayOfWeeks)
+    //         .build();


Do we need to show this in the sample? Having commented out code is not the best practice.
Kindly remove.

Thank you! Deleted

Sita04 · 2024-12-18T09:55:16Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+            String snapshotScheduleName, String scheduleDescription, int maxRetentionDays,
+            String storageLocation, String onSourceDiskDelete)
+          throws IOException, ExecutionException, InterruptedException, TimeoutException {
+    String startTime = "08:00";


This seems odd. Kindly add a relevant documentation on the time specification format.

START_TIME: the start time in the UTC time zone. The time must start on the hour.

For example:

2:00 PM PST must be specified as 22:00.
If you set a start time of 22:13, you receive an error. https://cloud.google.com/compute/docs/disks/scheduled-snapshots?authuser=0#gcloud

Sita04 · 2024-12-27T06:42:07Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+                             // .setDailySchedule(dailySchedule) //Set Daily Schedule
+                             // .setWeeklySchedule(weeklyCycle)    // Set Weekly Schedule


Same question here. I think we should remove this. Makes the code more complicated.

Thank you! Deleted

Sita04 · 2024-12-27T06:44:43Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+    ResourcePolicySnapshotSchedulePolicySnapshotProperties snapshotProperties =
+            ResourcePolicySnapshotSchedulePolicySnapshotProperties.newBuilder()
+                    .addStorageLocations(storageLocation)
+                    .build();


Move this to after line 102 to match the order with snapshotSchedulePolicy.

Thank you! Moved

Sita04 · 2024-12-27T06:52:33Z

compute/cloud-client/src/main/java/compute/snapshotschedule/ListSnapshotSchedules.java

+      for (ResourcePolicy resourcePolicy : resourcePoliciesClient.list(request).iterateAll()) {
+        list.add(resourcePolicy);
+      }
+    }
+    return list;


Suggesting to simplify this code. Call the API and get the return value. Iterate the return value, print it and then return it. Please refrain from using additional list data structures as it's not strictly needed here.

Thank you for the suggestions! Fixed code and added printing

Sita04 · 2024-12-27T06:58:05Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

+  public static Status editSnapshotSchedule(
+          String projectId, String region, String snapshotScheduleName)
+          throws IOException, InterruptedException, ExecutionException, TimeoutException {
+    String description = "Updated description11";


Please modify the value to be more descriptive.

Thank you! Some characters remained after testing. Extra characters have been removed.

Sita04 · 2024-12-27T06:59:26Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

+    String description = "Updated description11";
+    Map<String, String> snapshotLabels = new HashMap<>();
+    snapshotLabels.put("key", "value");
+    ResourcePolicyWeeklyCycleDayOfWeek dayOfWeek = ResourcePolicyWeeklyCycleDayOfWeek.newBuilder()


ditto. Please move all Compute API related code within the try catch block.

Sita04 · 2024-12-27T07:03:54Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

+      ResourcePolicy existingSchedule = resourcePoliciesClient
+              .get(projectId, region, snapshotScheduleName);


Do we need to get the existing schedule to set the new properties? The REST example in the docs looks like they override the old properties.

Have you tried constructing the patch request directly by setting the new properties, instead of retrieving the old ones and clearing them?

Yes we can construct the patch request directly. Thank you for the suggestion! Fixed code.

Sita04 · 2024-12-27T07:05:17Z

compute/cloud-client/src/test/java/compute/snapshotschedule/SnapshotScheduleIT.java

+    Status status = EditSnapshotSchedule.editSnapshotSchedule(
+            PROJECT_ID, REGION, SCHEDULE_NAME);
+
+    assertThat(status).isEqualTo(Status.DONE);


Suggesting to replace checking the status with another assertion. Status may not be always Done and this will cause flakiness.

Thank you for comment. Added new assertions

Kindly remove the assertion for Status.

Sita04 · 2024-12-28T15:28:23Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

@@ -17,11 +17,14 @@
 package compute.snapshotschedule;

 // [START compute_snapshot_schedule_edit]
+import static com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy.OnSourceDiskDelete.APPLY_RETENTION_POLICY;


Enums should be prefixed with their class name. Modify the import statement to:

import com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy. OnSourceDiskDelete;

Thank you! Fixed

Sita04 · 2024-12-28T15:29:00Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

@@ -17,6 +17,8 @@
 package compute.snapshotschedule;

 // [START compute_snapshot_schedule_create]
+import static com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy.OnSourceDiskDelete.KEEP_AUTO_SNAPSHOTS;


Enums should be prefixed with their class name. Modify the import statement to:

import com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy. OnSourceDiskDelete;

Thank you! Fixed

Sita04 · 2024-12-28T15:29:36Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

@@ -51,7 +53,7 @@ public static void main(String[] args)
    // https://cloud.google.com/compute/docs/disks/snapshots?authuser=0#selecting_a_storage_location
    String storageLocation = "US";
    // Determines what happens to your snapshots if the source disk is deleted.
-    String onSourceDiskDelete = "KEEP_AUTO_SNAPSHOTS";
+    String onSourceDiskDelete = KEEP_AUTO_SNAPSHOTS.toString();


Remove this variable. Inline the enum directly in line 81

Thank you! Fixed

Sita04 · 2024-12-28T15:30:30Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+      // Define the hourly schedule:
+      int snapshotInterval = 10; // Create a snapshot every 10 hours


Why are there two different comment styles? Kindly move the comment on line 72 to top.

Fixed comment styles.

Sita04 · 2024-12-28T15:31:06Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

      scheduler.clearDailySchedule().clearHourlySchedule();
      scheduler.setWeeklySchedule(weeklySchedule);

+      String onSourceDiskDelete = APPLY_RETENTION_POLICY.toString();


Remove variable and inline value.

Sita04 · 2024-12-28T15:32:49Z

compute/cloud-client/src/test/java/compute/snapshotschedule/SnapshotScheduleIT.java

+    Status status = EditSnapshotSchedule.editSnapshotSchedule(
+            PROJECT_ID, REGION, SCHEDULE_NAME);
+
+    assertThat(status).isEqualTo(Status.DONE);


Kindly remove the assertion for Status.

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

Sita04 · 2024-12-28T15:36:42Z

compute/cloud-client/src/test/java/compute/snapshotschedule/SnapshotScheduleIT.java

+
+package compute.snapshotschedule;
+
+import static com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy.OnSourceDiskDelete.APPLY_RETENTION_POLICY;


same comment here. Import the enum class instead of the actual value.

Thank you! Fixed

Sita04 · 2024-12-28T15:39:07Z

compute/cloud-client/src/main/java/compute/snapshotschedule/CreateSnapshotSchedule.java

+    String startTime = "08:00";
+    ResourcePolicySnapshotSchedulePolicySnapshotProperties snapshotProperties =
+            ResourcePolicySnapshotSchedulePolicySnapshotProperties.newBuilder()
+                    .addStorageLocations(storageLocation)


In the snapshot properties, we also have the guestFlush and labels.

Sita04 · 2024-12-28T15:40:49Z

compute/cloud-client/src/main/java/compute/snapshotschedule/EditSnapshotSchedule.java

+
+      ResourcePolicySnapshotSchedulePolicySchedule.Builder scheduler =
+              ResourcePolicySnapshotSchedulePolicySchedule.newBuilder();
+      scheduler.clearDailySchedule().clearHourlySchedule();


This can be removed as the scheduler is constructed from a new builder.

Thank you! Fixed

TetyanaYahodska · 2024-12-30T14:31:15Z

@Sita04 The documentation does not require showing how to create a snapshot schedule with guestFlush properties and labels. https://cloud.google.com/compute/docs/disks/scheduled-snapshots?authuser=0#create_snapshot_schedule

Sita04

Thanks for the changes!

* chore(job): migrate regions by associating them with an official product with a job_ prefix (#9883) * chore(endpoints): delete region 'swagger' in endpoints/multiple-versions (#9857) * chore(endpoints): delete region swagger to openapi-v1.yaml * chore(endpoints): delete region swagger to openapi-v2.yaml * chore(job): delete sample jobs_java_dependencies_beta (#9810) * chore(job): delete sample jobs_java_dependencies_beta * chore(job): delete region_tab 'jobs_java_dependencies_beta' and update 'google-api-services-jobs' version * feat(compute): add compute disk regional replicated sample (#9697) * Implemented compute_disk_regional_replicated sample, created test * Fixed zone * Fixed test * Fixed test * Fixed disk size * Fixed code as requested in the comment * feat(compute): add compute disk start/stop replication samples (#9650) * Implemented compute_disk_start_replication and compute_disk_stop_replication samples, created tests * Fixed test * Deleted not related classes * Fixed lint issue * Increased timeout * Split samples for zonal location * Fixed code * Fixed code * Increased timeout * Increased timeout * feat(tpu): add tpu vm create spot sample. (#9610) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_spot sample, created test * changed zone * Changed zone * Fixed empty lines and tests, deleted cleanup method * Changed zone * Deleted redundant test class * Increased timeout * Fixed test * feat(tpu): add tpu vm create startup script sample. (#9612) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_startup_script sample, created test * Fixed tests and empty lines * Changed zone * Deleted redundant test classes * Increased timeout * Fixed code * feat(tpu): add tpu queued resources create/get/delete samples (#9613) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Fixed test * Fixed tests * Fixed error massage * Fixed typo * Fixed zone * Fixed test * Fixed code * Deleted commented imports * Fixed code as requested in comments * feat(tpu): add tpu queued resources create spot (#9615) Add a code sample for tpu_queued_resources_create_spot * chore: add translate dev team for translate samples (#9888) b/385243174 * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Create, Delete, List, Get) (#9743) * sample codes for event threat detection custom modules * addressed comments * addressed comments * addressed comments * addressed comments * fix(compute): fixed compute_reservation_create_shared sample and test to use mocked client (#9840) * Fixed sample and test to use mocked client * Fixed code as requested in the comments * feat(compute): add compute instance create replicated boot disk sample (#9735) * Implemented compute_instance_create_replicated_boot_disk sample, created test * Fixed test * Fixed code as requested in the comments * Fixed Util class * Fixed code * feat(compute): add compute consistency group stop replication (#9694) * Implemented compute_consistency_group_create and compute_consistency_group_delete samples, created test * Implemented compute_consistency_group_stop_replication sample * Implemented compute_consistency_group_stop_replication sample * Created test and added needed classes for testing * Fixed test * Moved clean up methods * Added clean up methods for reservations * Fixed clean up method * Fixed clean up method * Added timeout * Reverted not related changes * Reverted not related changes * Reverted not related changes * Reverted not related changes * Fixed code * Split samples for zonal location * Added comments for methods * Fixed comments * feat(secretmanager): add optional ttl to create secret sample (#9889) * feat(secretmanager): add optional ttl to create secret sample * nit: Update secretmanager/src/main/java/secretmanager/CreateSecret.java Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * fix(secretmanager): fix comment indentation to resolve linting issues --------- Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * feat(tpu): add tpu queued resources list sample (#9614) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_list sample, created test * Fixed test * Fixed tests, deleted cleanup method * Fixed test * Fixed imports * feat(compute): add compute disk create secondary regional sample (#9641) * Implemented compute_disk_create_secondary_regional. created test * Fixed test * Fixed test * Fixed test * Fixed zone * Fixed naming * Fixed spaces * Fixed code * Fixed indentations * Fixed variable * Fixed code * Added cleanup methods * Fixed lint issue * Fixed lint issue * Fixed test * Fixed code * Fixed code * Fixed code * Deleted duplicated assertion * feat(compute): add compute disk create secondary sample. (#9643) * Implemented compute_disk_create_secondary sample, created test * Fixed code * Fixed variable * Fixed code * Merged changes from main * Fixed lint issue * fix(storage): migrate old region all to storagetransfer_transfer_all step 1 (#9917) * fix(job): remove old region create_job (#9914) * feat(compute): attach/ remove snapshot schedule to disk (#9791) * Implemented compute_snapshot_schedule_attach sample, created test * Implemented compute_snapshot_schedule_remove sample, created test * Fixed code * Fixed code as requested in the comments * feat(compute): add compute consistency group clone sample (#9885) * Implemented compute_consistency_group_clone and compute_consistency_group_clone_regional_disk samples, created tests * Fixed naming * feat(compute): add compute instance attach regional disk force sample (#9730) * Implemented compute_instance_attach_regional_disk_force sample, created test * Added clean up method * Fixed comments and parameters * Test order deleted * Fixed code * Fixed code * Fixed code * Increased timeout * Increased timeout * Increased timeout * Fixed code * Fixed code * Fixed code * Fixed naming * feat(compute): add compute disk create secondary custom sample (#9644) * Implemented compute_disk_create_secondary_custom sample, created test * Fixed code * Fixed variable * Fixed code * Fixed whitespace * Fixed whitespace * feat(compute): add compute snapshot schedule create/get/edit/list/delete samples (#9742) * Implemented compute_snapshot_schedule_delete and compute_snapshot_schedule_create samples, created test * Fixed test * Added compute_snapshot_schedule_get sample, created test * Fixed naming * Implemented compute_snapshot_schedule_edit, created test * Fixed naming * Implemented compute_snapshot_schedule_list sample, created test * Cleaned resources * Cleaned resources * Cleaned resources * Cleaned resources * Fixed test * Added comment * Fixed tests * Fixed code * Fixed code as requested in the comments * feat(compute): add compute disk create with snapshot schedule (#9788) * Implemented compute_disk_create_with_snapshot_schedule sample, created test * Fixed code * Fixed code * Fixed test * Fixed code * Fixed code as requested in the comments * Fixed lint issue * Fixed lint issue * Deleted redundant code * feat(tpu): add tpu queued resources time bound sample. (#9617) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_time_bound sample, created test * Changed zone for tpu * Cleanup resources * Fixed tests * Fixed test * Fixed code as requested in the comments * Fixed code as requested in the comments * fix(job): delete old region tag update_job_with_field_mask (#9940) * feat(job): migrate region tags to include product prefix (#9966) * fix(endpoints): migrate all regions (#9943) * fix: disable flakybot reporting (#9968) * chore(job): remove unused region tags (#9969) * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Update, Get Eff, List Eff, List Desc, Validate) (#9912) * sample codes for event threat detection custom modules * fixed lint * addressed comments * lint fix * addressed comments --------- Co-authored-by: OremGLG <[email protected]> Co-authored-by: eapl.me <[email protected]> Co-authored-by: Тетяна Ягодська <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: lovenishs04 <[email protected]> Co-authored-by: alarconesparza <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> Co-authored-by: Brian Dorsey <[email protected]>

Implemented compute_snapshot_schedule_delete and compute_snapshot_sch…

77d892e

…edule_create samples, created test

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 27, 2024

product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 27, 2024

TetyanaYahodska changed the title ~~Implemented compute_snapshot_schedule_delete and compute_snapshot_sch…~~ feat(compute): add compute snapshot schedule create/delete samples Nov 27, 2024

Merge branch 'main' into compute_snapshot_schedule_create

8a5b2f0

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 1, 2024

Fixed test

9520be3

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 1, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 1, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 1, 2024

TetyanaYahodska marked this pull request as ready for review December 1, 2024 17:59

TetyanaYahodska requested review from yoshi-approver and a team as code owners December 1, 2024 17:59

blunderbuss-gcf bot assigned telpirion Dec 1, 2024

TetyanaYahodska assigned minherz and unassigned telpirion Dec 1, 2024

TetyanaYahodska requested a review from minherz December 1, 2024 18:00

TetyanaYahodska mentioned this pull request Dec 1, 2024

feat(compute): add compute disk create with snapshot schedule #9788

Merged

11 tasks

Merge branch 'main' into compute_snapshot_schedule_create

dbf5596

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 2, 2024

TetyanaYahodska added 2 commits December 2, 2024 11:01

Added compute_snapshot_schedule_get sample, created test

361f09f

Fixed naming

7df8f9d

TetyanaYahodska added 2 commits December 18, 2024 22:04

Merge branch 'main' into compute_snapshot_schedule_create

7df09a5

Fixed code

d9657a0

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2024

Merge branch 'main' into compute_snapshot_schedule_create

4e633e8

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024

TetyanaYahodska requested a review from Sita04 December 23, 2024 14:49

TetyanaYahodska assigned Sita04 Dec 23, 2024

Sita04 requested changes Dec 27, 2024

View reviewed changes

TetyanaYahodska added 2 commits December 27, 2024 10:48

Merge branch 'main' into compute_snapshot_schedule_create

a34e97f

Fixed code as requested in the comments

1f80e08

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2024

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 27, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 27, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2024

Sita04 requested changes Dec 28, 2024

View reviewed changes

Fixed code as requested in the comments

9e093f4

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 30, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 30, 2024

Sita04 approved these changes Dec 30, 2024

View reviewed changes

Sita04 merged commit f328675 into main Dec 30, 2024
10 checks passed

Sita04 deleted the compute_snapshot_schedule_create branch December 30, 2024 16:53

		// .setDailySchedule(dailySchedule) //Set Daily Schedule
		// .setWeeklySchedule(weeklyCycle) // Set Weekly Schedule

		ResourcePolicy existingSchedule = resourcePoliciesClient
		.get(projectId, region, snapshotScheduleName);

		// Define the hourly schedule:
		int snapshotInterval = 10; // Create a snapshot every 10 hours


		package compute.snapshotschedule;

		import static com.google.cloud.compute.v1.ResourcePolicySnapshotSchedulePolicyRetentionPolicy.OnSourceDiskDelete.APPLY_RETENTION_POLICY;

feat(compute): add compute snapshot schedule create/get/edit/list/delete samples #9742

feat(compute): add compute snapshot schedule create/get/edit/list/delete samples #9742

Conversation

TetyanaYahodska commented Nov 27, 2024 • edited Loading

Description

Checklist

snippet-bot bot commented Dec 1, 2024 • edited Loading

iennae commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TetyanaYahodska Dec 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TetyanaYahodska Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TetyanaYahodska commented Dec 30, 2024

Sita04 left a comment

Choose a reason for hiding this comment

TetyanaYahodska commented Nov 27, 2024 •

edited

Loading

snippet-bot bot commented Dec 1, 2024 •

edited

Loading

TetyanaYahodska Dec 27, 2024 •

edited

Loading

TetyanaYahodska Dec 30, 2024 •

edited

Loading