fix(components): reset error when the component props have changed #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Take the "Text input - Default" story * change the `lapisField` to "hos" (i.e. making it an invalid field) * The component will show an error, because LAPIS shows an error * change the `lapisField` to "host" (i.e. making it a valid field again) Before: It would still show an error until you click "Try again" Now: It rerenders and doesn't show an error anymore Related to GenSpectrum/dashboards#530
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.14.2 (2025-02-06)Bug Fixes
|
This was referenced Feb 10, 2025
fix(components): gs-date-range-selector
value: make sure that strings are recognized as strings
#727
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lapisFieldto "hos" (i.e. making it an invalid field)lapisFieldto "host" (i.e. making it a valid field again)Before: It would still show an error until you click "Try again"
Now: It rerenders and doesn't show an error anymore
Related to GenSpectrum/dashboards#530
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.