381 auto height #713
Merged
381 auto height #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JonasKellerer
force-pushed
the
381-auto-height
branch
from
5a522d7 to
7569454
Compare
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.16.0 (2025-02-11)⚠ BREAKING CHANGES
Features |
fengelniederhammer
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Looks good in general 👍
The linter is complaining in a couple of places about missing hook dependencies.
Also the screenshot updates are missing. I'm also not sure whether it's a good idea to remove all the default heights. Do the diagrams still fit into the screen in the snapshot tests?
components/src/web-components/visualization/gs-aggregate.stories.ts
Outdated
Show resolved
Hide resolved
components/src/preact/sequencesByLocation/sequences-by-location-map.tsx
Outdated
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
381-auto-height
branch
from
54f5134 to
e698c92
Compare
JonasKellerer
force-pushed
the
381-auto-height
branch
from
e698c92 to
c8e8b02
Compare
JonasKellerer
force-pushed
the
381-auto-height
branch
from
c8e8b02 to
e8aef37
Compare
fengelniederhammer
requested changes
Feb 5, 2025
...tory-visualization-mutation-comparison--default-should-match-screenshot-1-chromium-linux.png
Outdated
Show resolved
Hide resolved
...ions-Story-visualization-mutations--on-table-tab-should-match-screenshot-1-firefox-linux.png
Outdated
Show resolved
Hide resolved
...-visualization-preva-a82c2-dataset-on-bubble-tab-should-match-screenshot-1-firefox-linux.png
Outdated
Show resolved
Hide resolved
...gate-Download-of-visualization-aggregate--default-should-match-snapshot-1-chromium-linux.txt
Outdated
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
381-auto-height
branch
2 times, most recently
from
022937d to
a7b4a96
Compare
fengelniederhammer
approved these changes
Feb 10, 2025
JonasKellerer
force-pushed
the
381-auto-height
branch
from
7159d88 to
496f1ca
Compare
…cally by content height BREAKING CHANGE: If height is not set, use automatic determined height by content instead of default value. Resolves #381
JonasKellerer
force-pushed
the
381-auto-height
branch
from
496f1ca to
3e76a19
Compare
fengelniederhammer
added a commit
that referenced
this pull request
Feb 11, 2025
…enomes are empty resolves #713
1 task
fengelniederhammer
added a commit
that referenced
this pull request
Feb 11, 2025
…enomes are empty resolves #713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #381
Summary
In this PR, the height is changed to an optional property with no default. If the value is not provided, either the full table is displayed, or the diagram with a fixed aspect ratio is shown.
Screenshot
Diagram with no height provided. Defaults to fixed aspect ratio.
Table with no height provided.
PR Checklist