Skip to content

Covid Advanced queries: broken with new filters #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anna-parker opened this issue Feb 4, 2025 · 1 comment
Open

Covid Advanced queries: broken with new filters #530

anna-parker opened this issue Feb 4, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@anna-parker
Copy link
Contributor

@corneliusroemer noticed this today, it only affects the advanced queries option: the advanced queries button nolonger checks if the input is valid and appears to send it as a filter to the other filter fields - this now causes an internal error

Image

@anna-parker anna-parker added the bug Something isn't working label Feb 4, 2025
fengelniederhammer added a commit to GenSpectrum/dashboard-components that referenced this issue Feb 6, 2025
* Take the "Text input - Default" story
* change the `lapisField` to "hos" (i.e. making it an invalid field)
* The component will show an error, because LAPIS shows an error
* change  the `lapisField` to "host" (i.e. making it a valid field again)
Before: It would still show an error until you click "Try again"
Now: It rerenders and doesn't show an error anymore

Related to GenSpectrum/dashboards#530
fengelniederhammer added a commit to GenSpectrum/dashboard-components that referenced this issue Feb 10, 2025
)

* Take the "Text input - Default" story
* change the `lapisField` to "hos" (i.e. making it an invalid field)
* The component will show an error, because LAPIS shows an error
* change  the `lapisField` to "host" (i.e. making it a valid field again)
Before: It would still show an error until you click "Try again"
Now: It rerenders and doesn't show an error anymore

Related to GenSpectrum/dashboards#530
@fengelniederhammer
Copy link
Contributor

It's not clear yet how we would fix it. GenSpectrum/dashboard-components#726 already provides a mitigation. We'll discuss later and come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants