Inconsistency between how fields can be specified for GET and form-data POST requests

[theosanderson]

For GET requests you can make a request:

https://lapis-main.loculus.org/cchf/sample/details?fields=accession,accessionVersion

However the corresponding POST request, which is what the Swagger UI generates, doesn't work:

curl -X 'POST' \
  'https://lapis-main.loculus.org/cchf/sample/details' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/x-www-form-urlencoded' \
  -d 'fields=accession,accessionVersion'`

But one can work around this with:

curl -X 'POST' \
  'https://lapis-main.loculus.org/cchf/sample/details' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/x-www-form-urlencoded' \
  -d 'fields=accession&fields=accessionVersion'

[fengelniederhammer]

We discussed it: Actually the current behavior looks ok from our perspective. fields=accession&fields=accessionVersion is the usual way how one would specify an "array" in URLs and forms. Maybe we included the fields=accession,accessionVersion version for backwards compatibility.

What remains to be done: clarify in the docs what works.

[theosanderson]

And I guess there's also a remaining (but maybe impossible) issue that Swagger generates this format

[fengelniederhammer]

Swagger generates this format

That is indeed unfortunate. But I guess we can't do much about it.