-
Notifications
You must be signed in to change notification settings - Fork 3
feat!(website): allow selecting fields to download in metadata and default to a shorter selection #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
commented
Feb 25, 2025
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.spec.ts
Outdated
Show resolved
Hide resolved
theosanderson
commented
Feb 26, 2025
theosanderson
commented
Feb 26, 2025
website/src/components/SearchPage/DownloadDialog/FieldSelector/FieldSelectorModal.tsx
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/FieldSelector/FieldSelectorModal.tsx
Show resolved
Hide resolved
fhennig
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for implementing that! Quite useful.
I just have a few small remarks.
website/src/components/SearchPage/DownloadDialog/FieldSelector/FieldSelectorModal.tsx
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/FieldSelector/FieldSelectorModal.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/FieldSelector/FieldSelectorModal.tsx
Outdated
Show resolved
Hide resolved
fhennig
approved these changes
Mar 19, 2025
Thanks for the review! |
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #850, resolves #851, resolves #3695
preview URL: https://select-fields.loculus.org/ebola-sudan/search?
Summary
Adds the capacity to select fields to download and defaults to a configured set of fields rather than to the full list.
The form to select these is quite nice. I haven't tried to merge it with the form that's used for selecting fields for the search fields and columns (or I did briefly but didn't succeed), but we can make an issue to do that in the future.
Breaking changes
You need to select which fields should be selected by default by adding the
includeInDownloadsByDefault: true
property in the values yaml. We should decide what this should be for Pathoplexus and make a PR before we merge this.I made a PR: pathoplexus/pathoplexus#404
Testing
I added integration tests to check the right number of columns are present. To achieve this I added a fixture. I would request relatively light touch reviewing on the integration tests.
Screenshot
PR Checklist
I tested that the downloads looked good. There are also some unit tests and an integration test.