-
Notifications
You must be signed in to change notification settings - Fork 7
fix(lapis): also return CSV header when there are no data #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lapis): also return CSV header when there are no data #1138
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.4.2 (2025-03-31)FeaturesBug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. There was more refactoring going on than I would have expected, but it looks good.
Only some minor issues.
lapis/src/test/kotlin/org/genspectrum/lapis/controller/MockData.kt
Outdated
Show resolved
Hide resolved
lapis/src/main/kotlin/org/genspectrum/lapis/response/ResponseCollections.kt
Show resolved
Hide resolved
lapis/src/main/kotlin/org/genspectrum/lapis/controller/LapisController.kt
Show resolved
Hide resolved
lapis/src/test/kotlin/org/genspectrum/lapis/controller/Helpers.kt
Outdated
Show resolved
Hide resolved
183c2c8
to
af52497
Compare
resolves #1090
PR Checklist
- [ ] All necessary documentation has been adapted.