[Internal QA] Update Company Cards logic to show domain cards #61706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…mpitable-corporate-cards
…mpitable-corporate-cards # Conflicts: # src/pages/workspace/WorkspaceInitialPage.tsx
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
VickyStash
changed the title
|
Start on reviewing today |
|
@DylanDylann can you review this today? |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2025-05-15.at.14.53.51.mov |
|
I see there are some places where we still use workspaceAccountID only. Should we update all these places to use getDomainOrWorkspaceAccountID Screen.Recording.2025-05-14.at.16.08.40.mov |
DylanDylann
reviewed
May 14, 2025
src/pages/workspace/companyCards/WorkspaceCompanyCardFeedSelectorPage.tsx
Outdated
Show resolved
Hide resolved
|
@puneetlath for safety, could you please trigger the ad-hoc build and invite the internal QA to test this PR? |
…mpitable-corporate-cards
|
🚧 @puneetlath has triggered a test app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Expensify Card seems to work well. Here's when the domain Expensify Card is set to preferred workspace with workspace feeds. And here's where it's set to one without workspace feeds: |
|
We have an issue with third party cards that is blocking me from testing it. Will hopefully be able to test them soon. |
|
Ok displaying cards on third party seems to work: And the assign card flow seems to work: But actually assigning the card seems to fail because we aren't passing the domainAccountID so it is trying to assign it as a workspace card. So we'll need to update that on the front-end and back-end, though it doesn't need to necessarily be in this PR. |
|
@DylanDylann do you need anything else from me in order to review? |
DylanDylann
approved these changes
May 15, 2025
puneetlath
requested changes
May 15, 2025
| import useOnyx from './useOnyx'; | ||
| import useWorkspaceAccountID from './useWorkspaceAccountID'; | ||
|
|
||
| const useCardsList = (policyID: string | undefined, selectedFeed: CompanyCardFeed | undefined): [CardList | undefined, ResultMetadata<CardList>] => { |
There was a problem hiding this comment.
Could we add a comment explaining what this hook is for.
There was a problem hiding this comment.
Added small comment: f3f646e
puneetlath
approved these changes
May 15, 2025
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊 (1/4)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/4)Meaningless Changes To Duration (1/3)Show entries
Show details
|
Performance Comparison Report 📊 (3/4)Meaningless Changes To Duration (2/3)Show entries
Show details
|
Performance Comparison Report 📊 (4/4)Meaningless Changes To Duration (3/3)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
@VickyStash could you please look into those ^? |
88 tasks
@puneetlath I don't think this PR could affect the app start time. Also, the same was reported in other PRs:
|
8 tasks
|
@VickyStash This PR might have introduced this bug, can you look into it? |
|
Seems to work 
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.46-12 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #60978
PROPOSAL: N/A
Tests
Part 1:
Please test the steps on both the domain and workspace feeds.
Part 2:
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Part 1:
web_test.mp4
web_test2.mp4
Part 2: