[Due for payment 2025-05-27] Update OpenPolicyCompanyCardsFeed to include domainAccountID for domain feeds

[puneetlath]

Part of the Cross Compatible Corporate Cards project

Main issue: https://github.com/Expensify/Expensify/issues/467915

Feature Description

We need to update the OpenPolicyCompanyCardsFeed API command to pass the domainAccountID when attempting to get the cards for a domain feed. That way the API can know that we want the domain feed cards and not the workspace feed cards and return them.

cc @VickyStash @koko57

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[VickyStash]

@puneetlath, have the BE updates been implemented yet?

[puneetlath]

Not yet. I'm working on them today.

[puneetlath]

@VickyStash looks like we will also need to update OpenAssignFeedCardPage. On the back-end, both OpenAssignFeedCardPage and OpenPolicyCompanyCardsFeed call the same API which returns the same data.

[VickyStash]

I'm going to be OOO 1-5th of May 🌴
So me or @koko57 will work on it after that!

[puneetlath]

This is live on staging now.

@DylanDylann would you be interested in implementing it since @VickyStash and @koko57 are OOO?

[DylanDylann]

Sure

[puneetlath]

Ok, great!

[VickyStash]

@DylanDylann @puneetlath I guess something was missed during the updates implementation. I see the card is returned by the API, but it doesn't display the list.

I think it's because the app tries to get the cards using ${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${selectedFeed} onyx key, but the cards are stored not under workspaceAccountID but under domainAccountID.

---

Another potential problem I've noticed is that useDefaultFundID hook tries to get domainFundID from Expensify cards settings only. I guess there can be a case when there are no Expensify cards in the domain, but there are some third-party cards.
@puneetlath Is it possible that cards from two different domains will have one policy set as preferred?

[puneetlath]

I think it's because the app tries to get the cards using ${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${selectedFeed} onyx key, but the cards are stored not under workspaceAccountID but under domainAccountID.

Good find. Can we update that?

Another potential problem I've noticed is that useDefaultFundID hook tries to get domainFundID from Expensify cards settings only. I guess there can be a case when there are no Expensify cards in the domain, but there are some third-party cards.
@puneetlath Is it possible that cards from two different domains will have one policy set as preferred?

Yes it is possible. There can be any number of domain feeds from any number of domains that will have this policy set as preferred.

[VickyStash]

Okay, so it sounds like both things need to be updated.
@DylanDylann Let me know if you want to do it as a follow up of your PR, otherwise I can take a look at it on Thursday!

[puneetlath]

This is not ready for payment. There's still more to do here as described here and here.

[VickyStash]

Updates:

• fixed useDefaultFundID hook (this issue)
• implemented useCardsList hook to fix the domain cards display
• created Draft PR with updates

TODOs:

• I need to look through the app for places where company cards are updated optimistically, to make sure the right onyx key is used (with domainID or workspaceAccountID), depending on the card.
• Test the updates and prepare the PR for review.

[VickyStash]

Updates:

• Updated getAllCardsForWorkspace function to return domain cards as well
• Fixed lint errors

I haven't had enough time today to finalize the PR, but I'll do my best to open it for review on Monday

[VickyStash]

The PR is ready for review: #61706

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@VickyStash Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Internal QA] Update Company Cards logic to show domain cards #61706

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @DylanDylann requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[RachCHopkins]

@puneetlath what is the pricetag here? Is it a standard $250?

[puneetlath]

Yes, that's correct.

[DylanDylann]

Regression Test

Part 1:

1. Open the Company Cards page. Make sure the assigned feeds are displayed.
2. Open any feed.
3. Make sure the list of assigned cards is displayed.
4. Try to open any card. Make sure you see the details.
5. Try to assign a new card to the feed.
6. Go to the workspace members. Open any. member page and see that the cards assigned to that member are displayed.

Part 2:

1. Have a workspace A without Expensify cards.
2. In the OD, open domain exensify cards and set preferred policy as workspace A.
3. In the ND open workspace A open Expensify cards section and make sure domain cards are visible.

[RachCHopkins]

Payment Summary:

• Contributor: @VickyStash no payment required
• Contributor+: @DylanDylann to be paid $250 via NewDot Manual Request

No upwork job.

[RachCHopkins]

No one to pay via upwork and no jobs to close.