Skip to content

[Due for payment 2025-05-28] [Due for payment 2025-05-27] Expensify Card - Member profile does not include any Expensify Card related information #62173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
jponikarchuk opened this issue May 16, 2025 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@jponikarchuk
Copy link

jponikarchuk commented May 16, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3272218
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung Galaxy A12 / Android 13
App Component: Workspace Settings

Action Performed:

Precondition: Have a member of Workspace with Expensify Card assigned.

  1. Go to staging.new.expensify.com
  2. Go to Workspace
  3. Go to Members
  4. Click on one of the members

Expected Result:

The member profiles list information related to Expensify Card, such as Assigned cards and a button to assign a new card.

Actual Result:

The member profiles does not list information related to Expensify Card.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
@jponikarchuk jponikarchuk added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkuoch
Copy link
Contributor

nkuoch commented May 16, 2025

@VickyStash can you look into this? Might be caused by #61706

@VickyStash
Copy link
Contributor

@VickyStash can you look into this? Might be caused by #61706

Yep, taking a look!

@VickyStash
Copy link
Contributor

I've just checked staging, and it works as expected for me:

staging-works.mp4

Do I miss any details?

@joekaufmanexpensify
Copy link
Contributor

Interesting. I just tested on staging and it's not working for me.

2025-05-16_11-22-24.mp4

@VickyStash
Copy link
Contributor

@joekaufmanexpensify Could you please add me as an admin to your workspace? [email protected]

@joekaufmanexpensify
Copy link
Contributor

Done!

@VickyStash
Copy link
Contributor

I'm checking it!

@VickyStash
Copy link
Contributor

I've prepared a PR!
@joekaufmanexpensify @alitoshmatov please take a look

@mvtglobally
Copy link

Unable to repro.

Image
Image

@arosiclair arosiclair removed the DeployBlockerCash This issue or pull request should block deployment label May 20, 2025
@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 20, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels May 20, 2025
@melvin-bot melvin-bot bot changed the title Expensify Card - Member profile does not include any Expensify Card related information [Due for payment 2025-05-27] Expensify Card - Member profile does not include any Expensify Card related information May 20, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-27. 🎊

Copy link

melvin-bot bot commented May 20, 2025

@nkuoch @mallenexpensify @nkuoch The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 21, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-27] Expensify Card - Member profile does not include any Expensify Card related information [Due for payment 2025-05-28] [Due for payment 2025-05-27] Expensify Card - Member profile does not include any Expensify Card related information May 21, 2025
Copy link

melvin-bot bot commented May 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-28. 🎊

Copy link

melvin-bot bot commented May 21, 2025

@nkuoch @mallenexpensify @nkuoch The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@alitoshmatov
Copy link
Contributor

I was C+ reviewer in PR, commenting here to be assigned

@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 23, 2025

Thanks for the ping @alitoshmatov, assigned, I might have missed it.

@alitoshmatov
Copy link
Contributor

alitoshmatov commented May 27, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: This was deploy blocker, I think this was mistake during implementation where the case was not considered on this PR - [Internal QA] Update Company Cards logic to show domain cards #61706

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: No discussion were created

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No regression needed, I think there is existing test for this case already.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 27, 2025
@mallenexpensify
Copy link
Contributor

Contributor+: @alitoshmatov due $250 via NewDot.

@alitoshmatov think anything needs to be updated for this test?

Image

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2025
@alitoshmatov
Copy link
Contributor

@mallenexpensify No, everything looks fine and covers this issue

Copy link

melvin-bot bot commented May 28, 2025

Payment Summary

Upwork Job

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants