Display MoneyRequestReport on Inbox and navigate to it from preview #60119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
f0df1d4 to
01ea0be
Compare
|
🚧 @shawnborton has triggered a test app build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Nice, feeling good so far. I commented elsewhere about the weird delay we get when the report loads (you see the empty state for a flash, and then the table rows come in) but I think we can handle that elsewhere. |
17 tasks
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
3 times, most recently
from
c6cfe19 to
2f46854
Compare
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
71ed84f to
e6f62f2
Compare
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
e6f62f2 to
508dc79
Compare
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
508dc79 to
eb19b89
Compare
melvin-bot
bot
requested review from
DylanDylann
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx
Outdated
Show resolved
Hide resolved
src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
Outdated
Show resolved
Hide resolved
src/pages/home/ReportScreen.tsx
Outdated
| const policy = policies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]; | ||
| const isTopMostReportId = currentReportIDValue?.currentReportID === reportIDFromRoute; | ||
| const didSubscribeToReportLeavingEvents = useRef(false); | ||
| const backTo = route?.params?.backTo as string; | ||
|
|
||
| const {canUseTableReportView} = usePermissions(); | ||
| const isSingleTransactionView = getIfReportIsSingleTransaction(report, reportTransactions, canUseTableReportView); |
There was a problem hiding this comment.
Suggested change
| const isSingleTransactionView = getIfReportIsSingleTransaction(report, reportTransactions, canUseTableReportView); | |
| const isSingleTransactionView = shouldRenderAsSingleTransactionView(report, reportTransactions, canUseTableReportView); |
There was a problem hiding this comment.
should I change the name of the const as well? because the name of the function was done like this to aligned with the const name.
so something like:
const shouldRenderAsSingleTransactionView = getShouldRenderAsSingleTransactionView(report, reportTransactions, canUseTableReportView);
?
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
5dc3d86 to
ffd6ee3
Compare
|
@DylanDylann please take a look. Note: There are several lint errors for newly added |
Kicu
commented
Apr 16, 2025
src/pages/home/ReportScreen.tsx
Outdated
| @@ -318,7 +318,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) { | |||
| const backTo = route?.params?.backTo as string; | |||
|
|
|||
| const {canUseTableReportView} = usePermissions(); | |||
| const isSingleTransactionView = getIfReportIsSingleTransaction(report, reportTransactions, canUseTableReportView); | |||
| const isReportSingleTransaction = getIfReportIsSingleTransaction(report, reportTransactions, canUseTableReportView); | |||
There was a problem hiding this comment.
getIsReportSingleTransaction
There was a problem hiding this comment.
(Note for myself remember to clean up styles with border radius)
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
Kicu
force-pushed
the
kicu/57509-use-money-report
branch
from
ffd6ee3 to
4137ffb
Compare
16 tasks
mountiny
approved these changes
Apr 23, 2025
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊 (1/10)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/10)Meaningless Changes To Duration (9/9)Show entries
Show details
|
Performance Comparison Report 📊 (2/10)Meaningless Changes To Duration (1/9)Show entries
Show details
|
Performance Comparison Report 📊 (3/10)Meaningless Changes To Duration (2/9)Show entries
Show details
|
Performance Comparison Report 📊 (4/10)Meaningless Changes To Duration (3/9)Show entries
Show details
|
Performance Comparison Report 📊 (5/10)Meaningless Changes To Duration (4/9)Show entries
Show details
|
Performance Comparison Report 📊 (6/10)Meaningless Changes To Duration (5/9)Show entries
Show details
|
Performance Comparison Report 📊 (7/10)Meaningless Changes To Duration (6/9)Show entries
Show details
|
Performance Comparison Report 📊 (8/10)Meaningless Changes To Duration (7/9)Show entries
Show details
|
Performance Comparison Report 📊 (9/10)Meaningless Changes To Duration (8/9)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
|
mountiny
removed
the
DeployBlockerCash
91 tasks
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀
|
8 tasks
|
Agree with Vit. Some higlights: One thing that happened here which might have some consequences is that Other than that:
|
Closed
18 tasks
|
I think the new way that we use to display the transactions in the report might have caused this bug: #60834 |
16 tasks
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR implements 2 things mainly
MoneyRequestReportViewin the context of Inbox - onReportScreen(/r/:reportIDroute) for the types of reports we want to showThis flowchart (hopefully) helps one understand how we render reportActions now:
Done
moneyRequestReportand if true -> renderMoneyRequestReportActionsListto show table view, instead of standardReportActionsViewSearchMoneyRequestReportandReportScreenTransactionPreviewandMoneyRequestReportPreviewwere simplified and refactored (but not much visual changes there)Fixed Issues
$ #57509
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
rec-reports-andr.mp4
Android: mWeb Chrome
Screen.Recording.2025-04-15.at.15.59.26.mov
iOS: Native
rec-reports-ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
rec-reports-web.mp4
MacOS: Desktop