[$125] Do not create optimistic transaction thread report on RequestMoney

[iwiznia]

Related to https://github.com/Expensify/Expensify/issues/433103

Conversation https://expensify.slack.com/archives/C08CZDJFJ77/p1742395185178209

The main goal of the project is to stop creating the transaction thread reports optimistically and instead have those be created when they are needed.

I have already deployed the PRs in the backend that make it so that we do not create the report in RequestMoney api request if we don't pass a transactionThreadReport and have this draft PR #58523 that stops sending it.

Issue Owner

Current Issue Owner: @sakluger / @abekkala

[VickyStash]

Re-posting updates for today:
I've opened a new Draft PR with updates, did a brief testing and it works as expected - no transaction thread is created.
Tomorrow I'm going to test my PR over the PR that creates transactionThread when needed, also I'm going to do some testing with offline flows to check how it works.

[VickyStash]

Today, during testing, I have found some issues related to not creating optimistic transaction threads.
Through the app, we have a lot of logic relying on checking if the report has only one transaction thread:
isOneTransactionThread
getOneTransactionThreadReportID

Example, of side effects:

1. I create 3 expenses in 1-1 chat. This way I have a report with several transaction.
2. I open one of the transactions -> transaction thread report is created for 1 out of 3 transactions.
3. Then, if I from the chat try to open the expenses overview, the app thinks that I have one-transaction-report and just shows that specific transaction thread (see the video below).

bug_example1.mp4

I'll need to look through every case in the app where it checks for one-transaction-thread and think about the alternative, maybe checking for transactions on its own.

[VickyStash]

I'm not sure that we can replace all of the one-transaction-thread checks (see my message above) through the app with checks for just transactions since transactions are not returned in the OpenApp response.

@iwiznia @mountiny Was it discussed before?

[VickyStash]

Another thing is offline behavior.

When I test my updates over the PR that creates a transaction thread when needed , in the offline opening, the transaction thread gives endless loading.
Is it the expected behavior?

offline_example2.mp4

[mountiny]

The OpenApp will definitely not return all the transactions for you, it probably should not return any once we have all the violations migrated to Auth. OpenReport will load those you need for the report.

[VickyStash]

The OpenApp will definitely not return all the transactions for you, it probably should not return any once we have all the violations migrated to Auth. OpenReport will load those you need for the report.

Okay, that means the app doesn't have information about report transactions before the report is opened.

Right now, the app uses transaction threads to identify the number of transactions in the report and what logic to apply.
If we update the app logic not to create transaction threads right away, which data can I use to handle some checks in case I haven't opened the report?

For example, 3 weeks ago some updates were merged, they includes checking for one-transaction-tread reports from the LHN level.

[iwiznia]

Is it the expected behavior?

No.

Right now, the app uses transaction threads to identify the number of transactions in the report and what logic to apply.
If we update the app logic not to create transaction threads right away, which data can I use to handle some checks in case I haven't opened the report?

I don't think I am following, I see that getOneTransactionThreadReportID only uses the reportActions not the transactions.

[VickyStash]

I don't think I am following, I see that getOneTransactionThreadReportID only uses the reportActions not the transactions.

I mean since we won't create transaction threads right away, all of the checks that use getOneTransactionThreadReportID/isOneTransactionThread won't work as expected

[iwiznia]

Maybe we can assume that if there are no actions is because we will optimistically create the transaction thread?