[Due for payment 2025-05-14] [Better Expense Report View] Report view follow-ups

[trjExpensify]

This is a list of follow up tasks related to the expense report view we're aware of to handle after this PR has merged: #58903

• Add selection to table on MoneyRequestReport page #59433 - @jnowakow
  • Receipt thumbnail in the expense row is too dark - to be handle in selection PR
  • [Better Expense Report View] Expense Reports - Hold violation appears and disappears when p2p expense is held #58856 - held on PR above.
  • Hover style on the selected transaction row is not correct Add selection to table on MoneyRequestReport page #59433 (comment)
  • Incorrect position and padding on the row on the reports page Add selection to table on MoneyRequestReport page #59433 (comment)
  • Add long press selection to money request report list #60430
• Data in the table not updating until a fresh - I think these all have the same RCA really - handled in Add selection to table on MoneyRequestReport page #59433
  • Chat bubble icons require a refresh to display after commenting in the expense thread
  • Some transaction amounts appear as $0.00 (I think I noticed it was receipt scans for me)
  • Deleted expense
  • After changing coding (i.e categories, tags, amounts etc)
  • [Better Expense Report View] Expense Reports - Merchant is still displayed in the row after merchant is removed #58855
• Correct handling for scrolling to the bottom - @Kicu is working on it in this PR Fix scrolling to bottom list on MoneyRequestReportView #59664
• One-expense report view
• [Due for payment 2025-04-16] [Better Expense Report View] Expense Reports - Unable to play video attachment #58833 - @JakubKorytko
• [Better Expense Report View] Keep the Report fields at the top of the table report view #59061 - @Kicu

Assigned a bunch of us to keep track of it. Let's link out to where the items are being taken care of as we chomp through them. Thanks!

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[Kicu]

thanks @trjExpensify!

Receipt thumbnail in the expense row is too dark

Can be done inside the selection PR because: 1) its a super small change 2) this PR will have to touch row styling anyway because of active/hover/selected styling and these styles are connected

Chat bubble icons require a refresh to display after commenting in the expense thread

[This is info mainly for developers] I believe this refreshing bug will have the same RCA as requiring a refresh after deleting an expense (CC @jnowakow so you are aware)

[Kicu]

There is one more bug we have noticed (but not created an issue yet).

Right now the expectation is that on Reports (old Search) if you choose Expense reports then every row that will be clicked will lead to new Report view. The bug is that sometimes when clicking on single rows we still show the report inside RHP.

This expectation is clear, but I wanted to discuss the fix of the bug with @mountiny and @luacmartins (especially I hope Carlos remembers parts of how search was originally designed 😅).

The root cause is that on Reports results we differentiate between a rows that represent a transaction:

and a row that represents a report:

These two have different onClick handlers and I made the logic so that once you click "transaction" row you always open RHP on search, and when you click on "report" row then you go to new view.

What I find surprising is that results from backend even when we do group-by: reports return both types of rows - whereas I'm thinking that perhaps we should display only the "report" row types there? 🤔
Here are the checks we do on data: https://github.com/software-mansion-labs/expensify-app-fork/blob/main/src/libs/SearchUIUtils.ts#L186-L196

Thoughts?

[mountiny]

What I find surprising is that results from backend even when we do group-by: reports return both types of rows - whereas I'm thinking that perhaps we should display only the "report" row types there? 🤔

Well, even the single expense report is just a report. Could you add a check that will compare the size of the transactions list and if its just one transaction open it in RHP?

@Kicu, also do you have an example of the confusing response? Are you suggesting that we return both the reports style data AND then we duplicate the transactions data in the transaction object response if its single expense report?

[Kicu]

Could you add a check that will compare the size of the transactions list and if its just one transaction open it in RHP?

Sure, but that wouldn't be a full final solution, because the expectation is that if you're on "Expenses" part of Reports then every click opens RHP, but if you're on the "Expense Reports" then every click opens in new view.

I can of course pass down some kind of context to know "from where" you are clicking but originally I thought I can base this on the type of result row.

do you have an example of the confusing response?

Actually I did a deeper dig into the FE code and I think its the frontends fault for treating these items sometimes as a report and sometimes as a transaction. So my bad. I think there is no need to change how backend returns stuff.
But thanks for confirming.

[trjExpensify]

Maybe somewhat related, but the expense report results should be getting an update to all have the new headers if that's helpful for you here:

[mountiny]

Ok great, sounds like this is covered now, I do code in the backend

[Kicu]

umm @trjExpensify this is the first time I'm seeing these new headers on results 😅 Is the expectation that we do it as part of the new Report View or something we plan to do later?
And yeah - it's helpful to know now that this will be updated 👍

[trjExpensify]

Is the expectation that we do it as part of the new Report View or something we plan to do later?

The empty state header is part of Report Creation UI, so we'll be updating them there to be consistent with that. Issue is here.

[Kicu]

oh ok thanks 👍

[luacmartins]

It seems like this is sorted out. Let me know if I can help with anything

[trjExpensify]

[This is info mainly for developers] I believe this refreshing bug will have the same RCA as requiring a refresh after deleting an expense (CC @jnowakow so you are aware)

Yeah, seems like pretty much anything I update in the expense detail screen doesn't update in the table automatically either.

[jnowakow]

@trjExpensify issues from Data in the table not updating until a fresh - I think these all have the same RCA really are resolved by #59433

[Kicu]

Fresh follow up: the PR to navigate to expense report table view in Inbox (#60119) grew quite big so we plan to merge it soon.
There is one known bug which that in Inbox context we're missing the small back/forward navigation when displaying a transaction in RHP.
I will fix this as a followup to make it smoother

[trjExpensify]

@Kicu I think we create an issue for that, and look to close this one out once the OP items are taken care of. I'll do that now and assign ya'll.

Edit: issue here: #60725

[trjExpensify]

This is close to being closed out.

Hover style on the selected transaction row is not correct & Incorrect position and padding on the row on the reports page - @Kicu are we still awaiting a PR for these, or did I miss it?

[Kicu]

this is the PR that will fix it: #61159 although its not ready yet.

Sorry I bundled this up with some other small UI tweaks to save time on creating PRs and reviewing so it took a while ;)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.41-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add Transaction and MoneyRequestReport UI tweaks #61159

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment through NewDot Manual Requests

[melvin-bot]

@allgandalf / @DylanDylann @trjExpensify @allgandalf / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[trjExpensify]

Going to close this now.

[Kicu]