Skip to content

[Due for payment 2025-05-22] [Report Creation UI] Add remaining empty state views (search result and report preview) #59502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trjExpensify opened this issue Apr 2, 2025 · 39 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Apr 2, 2025

👋 @SzymczakJ @mountiny @luacmartins @sumo-slonik @DylanDylann @allgandalf I realised this one hasn't been completed, so I'm creating an issue for it.


Empty report - preview

Current:
Image

Expected:

Image
  • Report title
  • empty state preview
  • Add expense dropdown button

Empty report - search result

Current:
(not displayed at all)
Image

Expected:

Image
  • Divider line between the report details and the expense lines
  • Bold report title and amount fields
  • Submitter avatar with workspace avatar overlaid
  • Secondary line with hyperlink to the parent chat (e.g From in

Note: We expect that new header of the expense reports in search results to be consistent across reports with expenses as well. I.e

Image

Thanks! CC: @shawnborton

Issue OwnerCurrent Issue Owner: @trjExpensify
@trjExpensify trjExpensify added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 2, 2025
Copy link

melvin-bot bot commented Apr 2, 2025

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@trjExpensify trjExpensify moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 2, 2025
@shawnborton
Copy link
Contributor

Looks great, happy to assist with the design review once we begin implementation on this one.

@JmillsExpensify
Copy link

We should probably add the expected headers for IOU and Invoice report types too right?

@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2025

@SzymczakJ @sumo-slonik who will tackle this one?

@SzymczakJ
Copy link
Contributor

We will take it and split it between us. In fact @sumo-slonik already started working on empty report preview.

@trjExpensify
Copy link
Contributor Author

We should probably add the expected headers for IOU and Invoice report types too right?

Sure! Here's them all:

Image

Note: ignore the expense details in line, just focus on the report headers.

@sumo-slonik
Copy link
Contributor

Hi, I think I can do it, please assign me :D

@trjExpensify
Copy link
Contributor Author

Nice, you're assigned!

@sumo-slonik
Copy link
Contributor

@trjExpensify
I have a question regarding the design of the empty component. It looks like this:

Image

And that's how I implemented it in the project:

Image

However, in the report, for a regular carousel element, the inner part of the component has a different background color than the outer part.

Image

Image

Shouldn't we aim for consistency here?

@shawnborton
Copy link
Contributor

the inner part of the component has a different background color than the outer part.

That's because that is the empty state of a receipt image. So I think we should still go with what we have mocked up.

@shawnborton
Copy link
Contributor

I have a few nitpicks about the current empty report preview you are showing though - let me know when the PR is ready to review and I will provide feedback there!

@sumo-slonik
Copy link
Contributor

We should probably add the expected headers for IOU and Invoice report types too right?

Sure! Here's them all:

Image Note: ignore the expense details in line, just focus on the report headers.

I have a question regarding the blue labels describing the report type:

Image

are they just for labels in the mockup, or do we want them in the application as well? I'm asking because they are not present in all the Figma designs, only in this one.

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2025

Nono those are just for you to understand the different types but check the avatars and the titles for each

@sumo-slonik
Copy link
Contributor

It seems to me that there are a few additional differences here that we shouldn't worry about, but I wanted to double-check:

A different table header
Image
A tab that doesn't exist yet
Image
Using new expense components in the Search tab
Image

Should we change this, or should we focus only on report headers and adding the empty state component for now?

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2025

Yeah I think lets keep this focused and only handle the headers and what is in the og

@shawnborton
Copy link
Contributor

Yup, agree with Vit's comments above. Happy to help with the review when you are ready too, please tag me!

@sumo-slonik
Copy link
Contributor

@mountiny
Could you check if the SEARCH request on the backend is accidentally filtering out the reports we create in our report flow?
I checked the report ID created via "create report," and it does not appear in the RS for such an RQ.

Request URL:
https://dev.new.expensify.com:8082/api/Search?

hash: 243428839
jsonQuery: {"type":"expense","status":"all","sortBy":"date","sortOrder":"desc","groupBy":"reports","filters":null,"inputQuery":"type:expense status:all sortBy:date sortOrder:desc groupBy:reports","hash":243428839,"recentSearchHash":422547233,"offset":0}

Screen.Recording.2025-04-04.at.15.07.15.mov

@luacmartins
Copy link
Contributor

I'm taking a look at ^

@luacmartins
Copy link
Contributor

@sumo-slonik the way Search works right now is:

  1. Select all transactions that match the search query
  2. Loop over all transactions and add their reportIDs to a list
  3. Get all reports in the list

So the reason why we don't return those reports is because they are empty. We'll have to make some significant changes to the Search API to allow returning empty reports.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

@sumo-slonik Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2025
@sumo-slonik
Copy link
Contributor

Hi @luacmartins. What's the status of the backend for the search returning reports without transactions?

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2025
@trjExpensify
Copy link
Contributor Author

Carlos has an Auth PR in review with @mountiny for that, I believe: https://github.com/Expensify/Auth/pull/14938

@luacmartins
Copy link
Contributor

Yea, PR is in review. Awaiting review from @mountiny

@mountiny
Copy link
Contributor

Merged and should be deployed tomorrow

@trjExpensify
Copy link
Contributor Author

Got a bit of a hold up with the Auth deploy it seems, still waiting here.

@trjExpensify
Copy link
Contributor Author

Auth PR has been deployed, we can proceed with the App PR: #59804

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

@sumo-slonik Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 29, 2025
@luacmartins luacmartins self-assigned this May 7, 2025
Copy link

melvin-bot bot commented May 13, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented May 15, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] Add remaining empty state views (search result and report preview) [Due for payment 2025-05-22] [Report Creation UI] Add remaining empty state views (search result and report preview) May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 15, 2025

@allgandalf / @DylanDylann @trjExpensify @allgandalf / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@trjExpensify
Copy link
Contributor Author

This is on prod now, so I think we can close.

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

9 participants