-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-05-22] [Report Creation UI] Add remaining empty state views (search result and report preview) #59502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new. |
Looks great, happy to assist with the design review once we begin implementation on this one. |
We should probably add the expected headers for |
@SzymczakJ @sumo-slonik who will tackle this one? |
We will take it and split it between us. In fact @sumo-slonik already started working on empty report preview. |
Hi, I think I can do it, please assign me :D |
Nice, you're assigned! |
@trjExpensify ![]() And that's how I implemented it in the project: However, in the report, for a regular carousel element, the inner part of the component has a different background color than the outer part. Shouldn't we aim for consistency here? |
That's because that is the empty state of a receipt image. So I think we should still go with what we have mocked up. |
I have a few nitpicks about the current empty report preview you are showing though - let me know when the PR is ready to review and I will provide feedback there! |
Nono those are just for you to understand the different types but check the avatars and the titles for each |
Yeah I think lets keep this focused and only handle the headers and what is in the og |
Yup, agree with Vit's comments above. Happy to help with the review when you are ready too, please tag me! |
@mountiny
Screen.Recording.2025-04-04.at.15.07.15.mov |
I'm taking a look at ^ |
@sumo-slonik the way Search works right now is:
So the reason why we don't return those reports is because they are empty. We'll have to make some significant changes to the Search API to allow returning empty reports. |
@sumo-slonik Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Hi @luacmartins. What's the status of the backend for the search returning reports without transactions? |
Carlos has an Auth PR in review with @mountiny for that, I believe: https://github.com/Expensify/Auth/pull/14938 |
Yea, PR is in review. Awaiting review from @mountiny |
Merged and should be deployed tomorrow |
Got a bit of a hold up with the Auth deploy it seems, still waiting here. |
Auth PR has been deployed, we can proceed with the App PR: #59804 |
@sumo-slonik Eep! 4 days overdue now. Issues have feelings too... |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-22. 🎊 For reference, here are some details about the assignees on this issue:
|
@allgandalf / @DylanDylann @trjExpensify @allgandalf / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
This is on prod now, so I think we can close. |
Uh oh!
There was an error while loading. Please reload this page.
👋 @SzymczakJ @mountiny @luacmartins @sumo-slonik @DylanDylann @allgandalf I realised this one hasn't been completed, so I'm creating an issue for it.
Empty report - preview
Current:

Expected:
Add expense
dropdown buttonEmpty report - search result
Current:

(not displayed at all)
Expected:
Note: We expect that new header of the expense reports in search results to be consistent across reports with expenses as well. I.e
Thanks! CC: @shawnborton
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: